-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for ECS Service Connect #727
Comments
Hello :) |
Hello John, did you find time for this FR? We're about to deply our solution, and this part is still a manual configuration job, after the deploy. thx |
Hello |
Hello John, is this FR already in the 0.25 rc? and , if so, how can I use it? thx |
Hi @slootmaekersdirk If you have any suggestion of what you feel the format should look like please do tell. Otherwise, I might simply allow to define the entire property CFN style in PS: You can already achieve the |
What are the properties that you today configure via the UI or in some other way? What does the connect config look like when you do |
Hello John,
For me the format of the syntax of ecs describe-services
Is enough for me, we don’t need a UX at the moment
Dirk
From: John Preston ***@***.***>
Date: Tuesday, 5 March 2024 at 07:28
To: compose-x/ecs_composex ***@***.***>
Cc: Dirk Slootmaekers ***@***.***>, Mention ***@***.***>
Subject: Re: [compose-x/ecs_composex] add support for ECS Service Connect (Issue #727)
Hi @slootmaekersdirk<https://github.com/slootmaekersdirk>
That is not in the 0.25, that will be a 1.x thing
The Connect Config<https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-service-serviceconnectconfiguration.html> is actually quite involved, although I already have all the components in place to make the integration easy, I need to play with finding a good UX for users to configure it.
If you have any suggestion of what you feel the format should look like please do tell.
Otherwise, I might simply allow to define the entire property CFN style in x-ecs_connect or x-network.ecs_connect, but that means more work for the user.
—
Reply to this email directly, view it on GitHub<#727 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACNLQBTD4HC7XR5DAIIFRFLYWVQYTAVCNFSM6AAAAABAPJJFGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZYGA2DSOJVGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I am adding the necessary to make it work in the 1.0 branch as this requires things that weren't originally in the docker compose specification but now are |
Hello John, please keep me up te date, when it is available for testing thx |
Planned for 1.1.0 :) PS: Next week I am at a summit, but should be done and delivered by end of March :) |
@slootmaekersdirk See #745 |
Hello John, |
Hey @slootmaekersdirk |
Implemented in #745 |
Is your feature request related to a problem? Please describe.
At the moment inter service communication is based on DNS lookup which is not ideal
Describe the solution you'd like
Amazon ECS Service Connect allows to communicate between ECS services in an easy way, not using DNS lookup
Additional context
What we need to add is
[
{
"portName": "test-port",
"clientAliases": [
{
"port": 80,
"dnsName": "test"
}
]
}
]
-> now we can access this service from another service through http://test:80
The text was updated successfully, but these errors were encountered: