Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for bind mount recursive #698

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Oct 15, 2024

Comment on lines 422 to 423
"recursive": {"type": "string", "enum": ["z", "Z"]},
"selinux": {"type": "string", "enum": ["enabled", "disabled", "writable", "readonly"]}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inversion?

Suggested change
"recursive": {"type": "string", "enum": ["z", "Z"]},
"selinux": {"type": "string", "enum": ["enabled", "disabled", "writable", "readonly"]}
"selinux": {"type": "string", "enum": ["z", "Z"]},
"recursive": {"type": "string", "enum": ["enabled", "disabled", "writable", "readonly"]}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed. I'm trying to reduce my caffeine addiction, but this seems to come with side effects

Copy link
Collaborator

@jhrotko jhrotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours enabled auto-merge (rebase) October 15, 2024 08:47
@glours glours merged commit 35c9659 into compose-spec:main Oct 15, 2024
8 checks passed
@ndeloof ndeloof deleted the bind_recursive branch October 15, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants