Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom filename for inject axe #150

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Custom filename for inject axe #150

merged 1 commit into from
Jan 17, 2023

Conversation

dkryaklin
Copy link
Contributor

@dkryaklin dkryaklin mentioned this pull request Dec 13, 2022
Open
@ttomaszewski
Copy link

Is there an ETA on when this may be released?

@Syed-Ahamed-G-S-Mohideen
Copy link

Syed-Ahamed-G-S-Mohideen commented Dec 30, 2022 •
edited
Loading

Related Issues
#134
#84
#73

@dkryaklin
Copy link
Contributor Author

Hello @avanslaars @sapegin! Please consider to merge this PR

sapegin
sapegin requested changes Jan 9, 2023
View reviewed changes
Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request adds compiled files that shouldn't be in Git.

Apart from that, I'm fine with the new fileName option. Though, something like axeCorePath would be much more clear.

@Syed-Ahamed-G-S-Mohideen
Copy link

Hello @dkryaklin can you make the changes requested. Thanks.

@dkryaklin dkryaklin force-pushed the custom-filename-for-inject-axe branch from 01843ef to 3f50bdd Compare January 12, 2023 15:58
@dkryaklin
Copy link
Contributor Author

@sapegin thanks! done

@dkryaklin
Copy link
Contributor Author

@sapegin kind reminder to review

sapegin
sapegin approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thamks!

@sapegin sapegin merged commit 91c72d2 into component-driven:master Jan 17, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@emyl3 emyl3 mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapegin sapegin sapegin approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkryaklin @ttomaszewski @Syed-Ahamed-G-S-Mohideen @sapegin