Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation folder not generated #41

Closed
crh225 opened this issue Dec 22, 2016 · 20 comments
Closed

documentation folder not generated #41

crh225 opened this issue Dec 22, 2016 · 20 comments

Comments

@crh225
Copy link

crh225 commented Dec 22, 2016

Hello, I have installed compodoc, and ran the command to generate the docs. it looks like it is working but no documentation folder is generated.

image

@crh225
Copy link
Author

crh225 commented Dec 22, 2016

here is my tsconfig

{
  "compilerOptions": {
    "target": "es5",
    "module": "commonjs",
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "sourceMap": true,
    "moduleResolution": "node",
    "skipDefaultLibCheck": true
  },
  "exclude": [
    "./node_modules",
    "./typings/main.d.ts",
    "./typings/main",
    "./typings/custom-signalr.d.ts"
  ],
  "filesGlob": [
    "./client/modules/**/*.ts",
    "./client/platform/**/*.ts",
    "!./node_modules/**",
    "./client/custom-typings.d.ts",
    "./typings/index.d.ts"
  ],
  "compileOnSave": false,
  "buildOnSave": false,
  "awesomeTypescriptLoaderOptions": {
    "useWebpackText": true
  }
}

@crh225
Copy link
Author

crh225 commented Dec 22, 2016

here is my routes

import { RouterModule } from '@angular/router';
import { CoreRoutes } from './shared/models/core.models';
import { AuthService } from './shared/services/auth.service';
import { AuthGuardService } from './shared/services/auth-guard.service';
import { config } from './app.constants';



export const routes: CoreRoutes = [
    { path: '', redirectTo: 'home', pathMatch: 'full', appData: config.APPDATA_WEBAPI },

  // Lazy async modules
  {
      path: 'swagger',
      canActivate: [AuthGuardService],
      appData: config.APPDATA_WEBAPI,
      loadChildren: () => new Promise(resolve => {
          (require as any).ensure([], (require: any) => {
              resolve(require('./+swagger/swagger.module').SwaggerModule);
          });
      })
  },
  {
      path: 'testbed',
      canActivate: [AuthGuardService],
      appData: config.APPDATA_WEBAPI,
      loadChildren: () => new Promise(resolve => {
          (require as any).ensure([], (require: any) => {
              resolve(require('./+testbed/testbed.module').TestbedModule);
          });
      })
  },
  {
      path: 'profile',
      canActivate: [AuthGuardService],
      appData: config.APPDATA_WEBAPI,
      loadChildren: () => new Promise(resolve => {
        (require as any).ensure([], (require: any) => {
            resolve(require('./+profile/profile.module').ProfileModule);
        });
    })
  },
  {
      path: 'security',
      canActivate: [AuthGuardService],
      appData: config.APPDATA_WEBAPI,
      loadChildren: () => new Promise(resolve => {
          (require as any).ensure([], (require: any) => {
              resolve(require('./+security/security.module').SecurityModule);
          });
      })
  },
  {
      path: 'error',
      canActivate: [AuthGuardService],
      appData: config.APPDATA_WEBAPI,
      loadChildren: () => new Promise(resolve => {
          (require as any).ensure([], (require: any) => {
              resolve(require('./+error/error.module').ErrorModule);
          });
      })
  }
];
export const authProviders = [
    AuthGuardService,
    AuthService
];
export const routing = RouterModule.forRoot(routes);

@vogloblinsky
Copy link
Contributor

Watching your console logs, the problem is in NavigatorComponent.
Can you paste the code if possible ?

@crh225
Copy link
Author

crh225 commented Dec 23, 2016

I can next Tuesday. I'm out for the holidays and don't have access to the source code. Great work!

@crh225
Copy link
Author

crh225 commented Dec 27, 2016

@vogloblinsky
Copy link
Contributor

It is the @injectable annotation that breaks the process. I will try to handle that, or emit a warning instead.

@crh225
Copy link
Author

crh225 commented Dec 27, 2016

Is it odd that I am using @Injectable componenets?

@manekinekko
Copy link
Member

@crh225 Components can not be Injectable. Only services can. You can mix and match @Component() with @Injectable().

@vogloblinsky
Copy link
Contributor

vogloblinsky commented Dec 28, 2016

Yes @crh225, @manekinekko is right, i fixed this issue by not stopping compodoc for this use-case; but you will get NavigatorComponent documented in Injectables entry instead of Components.

@crh225
Copy link
Author

crh225 commented Dec 28, 2016

@vogloblinsky, @manekinekko, thanks for teaching me more about angular in the process!

@crh225 crh225 closed this as completed Dec 28, 2016
@crh225
Copy link
Author

crh225 commented Dec 28, 2016

To confirm, that was the issue. It did not like injectable in the component.

@crh225
Copy link
Author

crh225 commented Dec 28, 2016

image
one hour later....fyi Im using yarn and offline npm packages. Probably my fault still

@crh225
Copy link
Author

crh225 commented Dec 28, 2016

going to add angular2-dependencies-graph globally in yarn and retry.

@crh225
Copy link
Author

crh225 commented Dec 28, 2016

@vogloblinsky, The documentation folder did get generated.

I have some feedback for enhancements. Is there way to make the menu navigation show/hide based on when you click the menu title? we use generated classes, one class for every db table and needless to say the list is very long. it would be helpful to be able to hide the list.
image

@crh225 crh225 reopened this Dec 28, 2016
@crh225
Copy link
Author

crh225 commented Dec 28, 2016

image
It is still giving me this issue now. When I type in ngd -h in command window it just closes.

@crh225
Copy link
Author

crh225 commented Dec 28, 2016

Im closing again. Sorry. I have to move on. I will pick this back up in the future when I get better at yarn. We just changed over to use npm offline packages and yarn. Im sure it is something I did.

@crh225 crh225 closed this as completed Dec 28, 2016
@vogloblinsky
Copy link
Contributor

@crh225, yep for the closing item in the menu, it is on my todo list

@vogloblinsky
Copy link
Contributor

vogloblinsky commented Dec 30, 2016

@crh225, For yarn support, it is a known issue : #23
Watching and waiting from yarn side to fix it.

@vogloblinsky
Copy link
Contributor

@crh225 toggle buttons int he menu added in last release ;)

@lock
Copy link

lock bot commented Oct 1, 2019

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem. Why locking ? Having issues with the most up-to-date context.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants