fix(deps): optional field in parameter table could be yes or no

fix #420
compodoc · Dec 28, 2017 · 96f3a0b · 96f3a0b
1 parent 827a3eb
commit 96f3a0b
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 11 deletions.
diff --git a/src/templates/partials/block-accessors.hbs b/src/templates/partials/block-accessors.hbs
@@ -58,9 +58,11 @@
                                                       {{/if}}
                                                       </td>
                                                       <td>
-                                                      {{#if optional}}
-                                                          true
-                                                      {{/if}}
+                                                        {{#if optional}}
+                                                            yes
+                                                        {{else}}
+                                                            no
+                                                        {{/if}}
                                                       </td>
                                                       <td>{{{comment}}}</td>
                                                     </tr>
@@ -142,9 +144,11 @@
                                                       {{/if}}
                                                       </td>
                                                       <td>
-                                                      {{#if optional}}
-                                                          true
-                                                      {{/if}}
+                                                        {{#if optional}}
+                                                            yes
+                                                        {{else}}
+                                                            no
+                                                        {{/if}}
                                                       </td>
                                                       <td>{{{comment}}}</td>
                                                     </tr>

diff --git a/src/templates/partials/block-constructor.hbs b/src/templates/partials/block-constructor.hbs
@@ -47,9 +47,11 @@
                                                       {{/if}}
                                                   </td>
                                                   <td>
-                                                      {{#if optional}}
-                                                          true
-                                                      {{/if}}
+                                                    {{#if optional}}
+                                                        yes
+                                                    {{else}}
+                                                        no
+                                                    {{/if}}
                                                   </td>
                                                   <td>{{{comment}}}</td>
                                                 </tr>

diff --git a/src/templates/partials/block-method.hbs b/src/templates/partials/block-method.hbs
@@ -93,7 +93,9 @@
                                                   </td>
                                                   <td>
                                                   {{#if optional}}
-                                                      true
+                                                      yes
+                                                  {{else}}
+                                                      no
                                                   {{/if}}
                                                   </td>
                                                   <td>{{{comment}}}</td>

diff --git a/test/src/cli/cli-generation-big-app.spec.ts b/test/src/cli/cli-generation-big-app.spec.ts
@@ -315,7 +315,7 @@ describe('CLI simple generation - big app', () => {
 
     it('should support optional', () => {
         let file = read('documentation/injectables/TodoStore.html');
-        expect(file).to.contain('true');
+        expect(file).to.contain('yes');
     });
 
     it('should support optional', () => {
-Original file line number
+Diff line change
@@ Expand Up / @@ -93,7 +93,9 @@ @@
                                                       </td>
                                                       <td>
                                                       {{#if optional}}
-                                                          true
+                                                          yes
+                                                      {{else}}
+                                                          no
                                                       {{/if}}
                                                       </td>
                                                       <td>{{{comment}}}</td>
@@ Expand Down @@