Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenSearch 2 by removing deprecated mapping types #3

Merged
merged 12 commits into from
Sep 22, 2022

Conversation

mauricebolhuis
Copy link

@mauricebolhuis mauricebolhuis commented Sep 22, 2022

As part of OpenSearch 2, support for mapping types is removed. As a result:

  • the type parameter is removed from rest end-points.
  • the include_type_name parameter is removed from API requests.

This pull request also removes these parameters from opensearch-rails.
See https://www.elastic.co/guide/en/elasticsearch/reference/7.17/removal-of-types.html for more info on mapping types and why they are being removed.

See also:

@mauricebolhuis mauricebolhuis changed the title Support OpenSearch 2 Support OpenSearch 2 by removing deprecated mapping types Sep 22, 2022
@mauricebolhuis mauricebolhuis marked this pull request as ready for review September 22, 2022 08:08
Copy link

@martijnbolhuis martijnbolhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ziet er goed uit. Ik heb nog één dingetje gevonden.

opensearch-model/spec/opensearch/model/indexing_spec.rb Outdated Show resolved Hide resolved
@mauricebolhuis mauricebolhuis merged commit e128c9e into main Sep 22, 2022
@mauricebolhuis mauricebolhuis deleted the feature/support-opensearch-2 branch September 22, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants