Skip to content

Commit

Permalink
ci: fix clippy failures on main (apache#10903)
Browse files Browse the repository at this point in the history
* ci: fix clippy

* retry ci
  • Loading branch information
jonahgao authored Jun 13, 2024
1 parent 1fc5f91 commit 2d26859
Show file tree
Hide file tree
Showing 8 changed files with 3 additions and 8 deletions.
2 changes: 1 addition & 1 deletion datafusion/expr/src/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -818,7 +818,7 @@ pub(crate) fn find_column_indexes_referenced_by_expr(
}
}
Expr::Literal(_) => {
indexes.push(std::usize::MAX);
indexes.push(usize::MAX);
}
_ => {}
}
Expand Down
1 change: 0 additions & 1 deletion datafusion/physical-expr/src/window/nth_value.rs
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ impl BuiltInWindowFunctionExpr for NthValue {

fn create_evaluator(&self) -> Result<Box<dyn PartitionEvaluator>> {
let state = NthValueState {
range: Default::default(),
finalized_result: None,
kind: self.kind,
};
Expand Down
1 change: 0 additions & 1 deletion datafusion/physical-expr/src/window/window_expr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,6 @@ pub enum NthValueKind {

#[derive(Debug, Clone)]
pub struct NthValueState {
pub range: Range<usize>,
// In certain cases, we can finalize the result early. Consider this usage:
// ```
// FIRST_VALUE(increasing_col) OVER window AS my_first_value
Expand Down
2 changes: 1 addition & 1 deletion datafusion/physical-plan/src/joins/hash_join.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ use std::fmt;
use std::sync::atomic::{AtomicUsize, Ordering};
use std::sync::Arc;
use std::task::Poll;
use std::{any::Any, usize, vec};
use std::{any::Any, vec};

use super::{
utils::{OnceAsync, OnceFut},
Expand Down
1 change: 0 additions & 1 deletion datafusion/physical-plan/src/joins/stream_join_utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
use std::collections::{HashMap, VecDeque};
use std::sync::Arc;
use std::usize;

use crate::joins::utils::{JoinFilter, JoinHashMapType};
use crate::metrics::{ExecutionPlanMetricsSet, MetricBuilder};
Expand Down
2 changes: 1 addition & 1 deletion datafusion/physical-plan/src/joins/symmetric_hash_join.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ use std::any::Any;
use std::fmt::{self, Debug};
use std::sync::Arc;
use std::task::{Context, Poll};
use std::{usize, vec};
use std::vec;

use crate::common::SharedMemoryReservation;
use crate::handle_state;
Expand Down
1 change: 0 additions & 1 deletion datafusion/physical-plan/src/joins/test_utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
//! This file has test utils for hash joins
use std::sync::Arc;
use std::usize;

use crate::joins::utils::{JoinFilter, JoinOn};
use crate::joins::{
Expand Down
1 change: 0 additions & 1 deletion datafusion/physical-plan/src/joins/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ use std::future::Future;
use std::ops::{IndexMut, Range};
use std::sync::Arc;
use std::task::{Context, Poll};
use std::usize;

use crate::metrics::{self, ExecutionPlanMetricsSet, MetricBuilder};
use crate::{ColumnStatistics, ExecutionPlan, Partitioning, Statistics};
Expand Down

0 comments on commit 2d26859

Please sign in to comment.