Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/Lint #4187

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Bug/Lint #4187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions cla-backend-go/v2/sign/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (
"errors"
"fmt"
"io"
"io/ioutil"
"strings"

log "github.com/communitybridge/easycla/cla-backend-go/logging"
Expand Down Expand Up @@ -153,7 +152,6 @@ func Configure(api *operations.EasyclaAPI, service Service, userService users.Se

log.WithFields(f).Debugf("data: %+v", data)


// err := service.SignedIndividualCallbackGithub(ctx, payload, params.InstallationID, params.ChangeRequestID, params.GithubRepositoryID)
// if err != nil {
// return sign.NewIclaCallbackGithubBadRequest()
Expand Down
16 changes: 8 additions & 8 deletions cla-backend-go/v2/sign/models.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,14 +359,14 @@ type DocuSignUpdateDocumentResponse struct {
}

type DocuSignXMLData struct {
XMLName xml.Name `xml:"EnvelopeStatus"`
EnvelopeID string `xml:"EnvelopeID"`
Status string `xml:"Status"`
Subject string `xml:"Subject"`
UserName string `xml:"UserName"`
Email string `xml:"Email"`
SignedDateTime string `xml:"SignedDateTime"`
// Include other fields as necessary
XMLName xml.Name `xml:"EnvelopeStatus"`
EnvelopeID string `xml:"EnvelopeID"`
Status string `xml:"Status"`
Subject string `xml:"Subject"`
UserName string `xml:"UserName"`
Email string `xml:"Email"`
SignedDateTime string `xml:"SignedDateTime"`
// Include other fields as necessary
}

type Signer struct {
Expand Down
Loading