Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "/easycla" trigger for GitLab #3844

Closed
jarias-lfx opened this issue Mar 9, 2023 · 4 comments
Closed

Add "/easycla" trigger for GitLab #3844

jarias-lfx opened this issue Mar 9, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@jarias-lfx
Copy link

Summary

Please add "/easycla" action for GitLab

Background

The use of "/easycla" comment in GitHub is a critical feature used by maintainers, contributors and support to trigger EasyCLA bot when required. The use of this feature is very important to have for GitLab as well as we would have no other way to trigger EasyCLA checks in a MR.

@jarias-lfx jarias-lfx added the enhancement New feature or request label Mar 9, 2023
@dealako
Copy link
Member

dealako commented Mar 17, 2023

  1. Need to ensure we are subscribed to receive comment events from GitLab via the webhook
  2. Need to add a comment handler routine to review the comments to determine if the current/most-recent comment includes the /easycla command.
  3. If the /easycla command is recognized, then the logic should execute the merge request check logic which would re-evaluate the authorized users and ultimately update the GitLab status on the GitLab UI.

nickmango added a commit that referenced this issue Mar 24, 2023
- Added /easycla command feature that enables MR check against the EasyCLA bot

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit that referenced this issue Mar 24, 2023
- Added /easycla command feature that enables MR check against the EasyCLA bot

Signed-off-by: Harold Wanyama <[email protected]>
dealako pushed a commit that referenced this issue Mar 24, 2023
nickmango added a commit that referenced this issue Mar 27, 2023
- Update existing PR instead of new comment for /easycla command trigger

Signed-off-by: Harold Wanyama <[email protected]>
@thakurveerendras
Copy link
Contributor

Tested issue on dev site and covered below scenario & found that it is fixed as expected.

Scenario 1 : Comments is disabled on existing setup

Steps & results :

  1. Comments is disabled on existing setup
  2. Cla is already enforced for existing GitLab group
  3. Now disable cla enforced
  4. See-Cla hooks configurations disappears at GitLab settings page
  5. Re-enabled cla enforced
  6. See-Webbooks re-added with comment box is checked as expected,

Scenario 2 : Added fresh GitLab group

Steps & results :

  1. Configure(install) new GitLab group
  2. See-cla is not added under Webbooks
  3. Cla enforced GitLab project
  4. See-Webbooks added with comment box is checked as expected,

Scenario 3 : checked /easycla comment behaviour

  1. GitLab MR gated with not covered
  2. Add /easycla comment
  3. See-Note Hook activity logs generated
  4. Singed ICLA MR
  5. See-MR get covered
  6. Add /easycla comment
  7. See-Note Hook activity logs generated
    image
    image

@thakurveerendras
Copy link
Contributor

As confirmed by @jarias-lfx over slack , issue is properly fix & deployed to production too, So moving issue status Done
image

@shyam-goshike
Copy link

Closing as per comments from @jarias-lfx

nickmango pushed a commit to nickmango/easycla that referenced this issue Apr 19, 2023
- Ignore web flow commit author

Signed-off-by: Harold Wanyama <[email protected]>
nickmango pushed a commit to nickmango/easycla that referenced this issue Apr 19, 2023
- Ignore web flow commit author

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit that referenced this issue Apr 19, 2023
umeshlumbhani247 pushed a commit that referenced this issue Apr 24, 2023
- Ignore web flow commit author

Signed-off-by: Harold Wanyama <[email protected]>
Signed-off-by: Umesh Lumbhani <[email protected]>
umeshlumbhani247 pushed a commit that referenced this issue Apr 24, 2023
- Ignore web flow commit author

Signed-off-by: Harold Wanyama <[email protected]>
Signed-off-by: Umesh Lumbhani <[email protected]>
umeshlumbhani247 pushed a commit that referenced this issue Apr 24, 2023
- Ignore web flow commit author

Signed-off-by: Harold Wanyama <[email protected]>
Signed-off-by: Umesh Lumbhani <[email protected]>
nickmango added a commit to nickmango/easycla that referenced this issue Apr 28, 2023
- Added search by name to make comparisons with search by email

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit to nickmango/easycla that referenced this issue Apr 28, 2023
- Added search by name to make comparisons with search by email

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit that referenced this issue Apr 30, 2023
nickmango added a commit to nickmango/easycla that referenced this issue Jul 14, 2023
- Handled enqueued action for a given PR added to a merge group

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit that referenced this issue Jul 14, 2023
nickmango added a commit to nickmango/easycla that referenced this issue Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants