Feat/prsd 404 create template #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WHile some changes have been made to the controller to support the validation functionality, I expect to refactor the server code (e.g. improving naming)
AEPR
commented
Oct 28, 2024
AEPR
commented
Oct 29, 2024
...in/kotlin/uk/gov/communities/prsdb/webapp/controllers/ManageLocalAuthorityUsersController.kt
Outdated
Show resolved
Hide resolved
AEPR
commented
Oct 29, 2024
rowanhill
reviewed
Oct 31, 2024
src/main/kotlin/uk/gov/communities/prsdb/webapp/constants/InternationalisationKeys.kt
Outdated
Show resolved
Hide resolved
...in/kotlin/uk/gov/communities/prsdb/webapp/controllers/ManageLocalAuthorityUsersController.kt
Show resolved
Hide resolved
...in/kotlin/uk/gov/communities/prsdb/webapp/controllers/ManageLocalAuthorityUsersController.kt
Outdated
Show resolved
Hide resolved
...k/gov/communities/prsdb/webapp/validation/bindingResultExtensions/BindingResultExtensions.kt
Outdated
Show resolved
Hide resolved
...k/gov/communities/prsdb/webapp/validation/bindingResultExtensions/BindingResultExtensions.kt
Outdated
Show resolved
Hide resolved
...in/kotlin/uk/gov/communities/prsdb/webapp/controllers/ManageLocalAuthorityUsersController.kt
Outdated
Show resolved
Hide resolved
rowanhill
reviewed
Nov 1, 2024
...in/kotlin/uk/gov/communities/prsdb/webapp/controllers/ManageLocalAuthorityUsersController.kt
Outdated
Show resolved
Hide resolved
...k/gov/communities/prsdb/webapp/validation/bindingResultExtensions/BindingResultExtensions.kt
Outdated
Show resolved
Hide resolved
...k/gov/communities/prsdb/webapp/validation/bindingResultExtensions/BindingResultExtensions.kt
Outdated
Show resolved
Hide resolved
…o find first validation failure per field
…ted targetFunction signature
This has the benefit of guaranteeing we won't accidentally not show some errors, but it has the drawback that the errors are in an arbitrary order in the summary.
Travis-Softwire
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft review, I will continue making changes to it before proposing a merge. The main area that I know still needs improving is the logic and code placement of everything in the controller. That is to say - there are some classes I've left in that file that need their own home and some of the functions and naming are difficult to read.
What I would find useful though would be a review of the Thymeleaf templates and fragments I've written as they're essentially independant of the controller logic (with the obvious exception of property names).