Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Footers are now customizable #151

Merged
merged 6 commits into from
Apr 19, 2023
Merged

Footers are now customizable #151

merged 6 commits into from
Apr 19, 2023

Conversation

adamdavies1
Copy link

@adamdavies1 adamdavies1 commented Apr 14, 2023

Description

  • Can now customise footer with the new footer array with the form.
"footer": [
    {
      "href": "https://www.gov.uk/government/publications/community-ownership-fund-privacy-notice/community-ownership-fund-privacy-notice",
      "text": "Privacy test"
    },
    {
      "href": "https://www.google.com",
      "text": "Cookies test"
    },
    {
      "href": "https://www.gov.uk/government/publications/community-ownership-fund-privacy-notice/community-ownership-fund-privacy-notice",
      "text": "Accessibility Statement test"
    },
    {
      "href": "https://www.gov.uk/government/publications/community-ownership-fund-privacy-notice/community-ownership-fund-privacy-notice",
      "text": "Contact Us test"
    }
  ]

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce
the testing if necessary.

Before PR's can be merged they will need to be tested by QA and approved where
applicable. To flag the change to QA assign @XGovFormBuilder/qa as one of the reviewers.

  • Add a the new footer array to a json form
  • navigate to that form and see the changes take effect

Checklist:

  • My changes do not introduce any new linting errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and versioning
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have rebased onto main and there are no code conflicts

@adamdavies1 adamdavies1 marked this pull request as ready for review April 18, 2023 08:47
Copy link

@tferns tferns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! 👍 🚢

runner/src/server/views/layout.html Show resolved Hide resolved
@adamdavies1 adamdavies1 merged commit 4698f28 into main Apr 19, 2023
@adamdavies1 adamdavies1 deleted the FS-2428-footer-config branch April 19, 2023 09:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants