Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Fs 2368 add another data #148

Merged
merged 7 commits into from
Apr 17, 2023
Merged

Fs 2368 add another data #148

merged 7 commits into from
Apr 17, 2023

Conversation

adamdavies1
Copy link

@adamdavies1 adamdavies1 commented Apr 13, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Please also include any acceptance criteria if you have any.
JIRA: https://digital.dclg.gov.uk/jira/browse/FS-2368

  • Changed the answers for the MultiInputComponent to be a json format. Example of the new data is bellow
{
  "name": "Digital Form Builder - Runner add-another",
  "questions": [
    {
      "question": "First page",
      "fields": [
        {
          "key": "MultiInputField",
          "title": "MultiInputField",
          "type": "multiInput",
          "answer": [
            {
              "type-of-revenue-cost": "Town Funding",
              "value": "100000"
            },
            {
              "type-of-revenue-cost": "City",
              "value": "4545"
            }
          ]
        }
      ]
    }
  ],
  "metadata": {
    "application_id": "efg-1256",
    "isSummaryPageSubmit": true,
    "form_session_identifier": "efg-1256",
    "paymentSkipped": false
  }
}

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce
the testing if necessary.

Before PR's can be merged they will need to be tested by QA and approved where
applicable. To flag the change to QA assign @XGovFormBuilder/qa as one of the reviewers.

  • Go the the add-another form
  • Add a new inputs
  • See if the summary page is still displaying the correct data
  • Check to see if the form data submitted on save per page is in the correct format

Checklist:

  • My changes do not introduce any new linting errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and versioning
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have rebased onto main and there are no code conflicts
  • I have checked deployments are working in all environments

@adamdavies1 adamdavies1 marked this pull request as ready for review April 13, 2023 16:10
@@ -481,7 +481,7 @@
"title": "Update form in application store",
"type": "savePerPage",
"outputConfiguration": {
"savePerPageUrl": "https://webhook.site/ba83e49b-cdd1-46e9-9c04-c89cfa651752"
"savePerPageUrl": "True"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this changed on purpose to a string? Is the "True" just for a truthy evaluation?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a basically a revert, something was push by mistake in another pr

@adamdavies1 adamdavies1 merged commit edefd56 into main Apr 17, 2023
@adamdavies1 adamdavies1 deleted the FS-2368-add-another-data branch April 17, 2023 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants