Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for private s3 mvn repos #12

Closed
mikub opened this issue Dec 14, 2020 · 1 comment
Closed

Add support for private s3 mvn repos #12

mikub opened this issue Dec 14, 2020 · 1 comment

Comments

@mikub
Copy link
Contributor

mikub commented Dec 14, 2020

Currently private s3 mvn repo support is achievable via following workaround requiring rebuild:
https://github.com/mikub/titanoboa/wiki/Server-Configuration#using-private-s3-maven-repositories

It would be nice if this would work out of the box, currently people have to maintain a separate build/fork to make this work.

mikub added a commit that referenced this issue Dec 16, 2020
…endencies it is automatically initiated and registered in aether prior to other dependencies' retrieval. This way private s3 can be supported without including s3-wagon-private in project.clj by default (and potentially unnecessarily bloating titanoboa since most ppl dont need s3 private mvn repos)
@mikub
Copy link
Contributor Author

mikub commented Dec 16, 2020

Added new feature here: 1a3056b
Whenever s3-wagon-private dependency is found in ext-dependencies it is automatically initiated and registered in aether prior to other dependencies' retrieval. This way private s3 can be supported without including s3-wagon-private in project.clj by default (and potentially unnecessarily bloating titanoboa since most ppl dont need s3 private mvn repos).

Tested this with a sample private s3 mvn repo and by adding [s3-wagon-private "1.3.2" :exclusions [ch.qos.logback/logback-classic]] into ext-dependencies.

Also there seemed to be some issues with consistency of mvn metadata for [s3-wagon-private "1.3.4"], so I am sticking to 1.3.2 at the moment.

@mikub mikub closed this as completed Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant