-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database drivers added to ext-dependencies are not found #11
Comments
I created a clone of c3p0 with the bug fix. Since the main repo seems reluctant with releasing this fix here is a build with it: So far using this dependency seems to fix the issue. |
This still does not seem to fix the issue in all test cases (e.g. in test mode from repl this works but in standalone server mode it does not). |
Seems like the branch I deployed to clojars still did not have the patch. It is in Mule's mvn repo: https://repository.mulesoft.org/releases/ As far as this one is available no need to repackage and redeploy the patch to clojars then. |
This is now fixed in 1.0.0.-alfa.1 |
Titanoboa uses C3p0 connection pool and due to this bug swaldman/c3p0#105 any DB driver classes have to be loaded on the main class loader.
This means that any DB drivers you put into ext-dependencies will not be recognized by C3p0 and would have to be put into project.clj dependencies.
This requires re-build and is not in line with how Titanoboa is intended to be used (i.e. modular & easily extensible).
E.g. Postgres driver used in the following example https://github.com/mikub/titanoboa/wiki/Server-Configuration#non-core-systems has to be currently put into project.clj dependencies - or simply just copied into the /lib folder (the easiest workaround).
The text was updated successfully, but these errors were encountered: