feat : Account Vanishing #6098
feat : Account Vanishing #6098
Conversation
| @@ -11,7 +10,6 @@ import android.net.Uri | |||
| import android.os.Bundle | |||
| import android.text.Editable | |||
| import android.text.TextWatcher | |||
| import android.view.KeyEvent | |||
There was a problem hiding this comment.
For maintainers:
I noticed there were unused imports so I have removed this two above imports.
This comment was marked as outdated.
This comment was marked as outdated.
app/src/main/res/values/strings.xml
Outdated
| <string name="account">Account</string> | ||
| <string name="vanish_account">Vanish Account</string> | ||
| <string name="account_vanish_request_confirm_title">Vanish account warning</string> | ||
| <string name="account_vanish_request_confirm"><![CDATA[Vanishing is a <b>last resort</b> and should <b>only be used when you wish to stop editing forever</b> and also to hide as many of your past associations as possible.<br/><br/>Account deletion on Wikipedia is done by changing your account name to make it so others cannot recognize your contributions in a process called account vanishing. <b>Vanishing does not guarantee complete anonymity or remove contributions to the projects</b>.]]></string> |
There was a problem hiding this comment.
It should say "Account deletion on Wikimedia Commons".
|
More on the text (maybe to be discussed later): I think the dialog text can be shorter (for the typically small space of the dialog), partly because the user will read it later anyway in the web view in the current workflow. Instead we might want to include a link to read more about vanishing, besides "Cancel" and "Vanish account". Link: https://meta.wikimedia.org/wiki/Account_vanishing |
|
Nice catch whym! I directly copied the string from Wikipedia app. |
|
@whym Would you mind creating a separate issue about #6098 (comment)? The high priority for now is to get this feature released as soon as possible for policy reasons, a second phase can focus on UX improvements. :-) Thanks a lot! |
Fixes
Description
Caution
Don't enter your main account credentials while testing the account vanishing feature.
Steps to follow:-
Creating a test account for testing account deletion (New Google Play policy about account deletion #5202) original account is {your username}
Steps to delete via app:-
Click on hamburger menu -> go to settings -> Scroll Down -> Click on Vanish Account.
Room for more improvement(once this merged)
🌟 h/to thanks @dbrant for this PR. Helped a lot.
🌟 h/to thanks @whym for helping creating multiple accounts :)
Have squashed merge the commits for ease in merging.
Video
delete.mp4