Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1437 : Button that opens Google Maps shows always only the coordinates of the first chosen mark #1446

Merged
merged 1 commit into from
Apr 16, 2018

Conversation

kamilya35231
Copy link
Contributor

Fixes #1437
Google maps now receive updated location

Tested on Xiomi Redmi 4a device

@codecov-io
Copy link

Codecov Report

Merging #1446 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1446   +/-   ##
======================================
  Coverage     3.3%    3.3%           
======================================
  Files         128     128           
  Lines        6839    6839           
  Branches      669     669           
======================================
  Hits          226     226           
  Misses       6598    6598           
  Partials       15      15
Impacted Files Coverage Δ
.../fr/free/nrw/commons/nearby/NearbyMapFragment.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b012ce4...7eab94b. Read the comment docs.

@misaochan misaochan requested a review from neslihanturan April 16, 2018 07:27
@misaochan misaochan changed the base branch from master to 2.7.x-release April 16, 2018 07:28
@misaochan misaochan changed the base branch from 2.7.x-release to master April 16, 2018 07:29
@misaochan
Copy link
Member

Thanks for the PR, @kamilya35231 ! We will test and merge asap.

Note to dev team: We will need to cherry pick this from master prior to 2.7.1 release (see #1400 )

@neslihanturan neslihanturan changed the title Fix for #1437 Fix for #1437 : Button that opens Google Maps shows always only the coordinates of the first chosen mark Apr 16, 2018
@neslihanturan
Copy link
Collaborator

Thanks @kamilya35231 , congrats your first time contribution 💃

@neslihanturan neslihanturan changed the base branch from master to 2.7.x-release April 16, 2018 11:36
@neslihanturan neslihanturan changed the base branch from 2.7.x-release to master April 16, 2018 11:36
@neslihanturan neslihanturan merged commit 35a7d49 into commons-app:master Apr 16, 2018
misaochan pushed a commit that referenced this pull request Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants