Contributions loading fix

[maskaravivek]

Fixes #1393

[codecov-io]

Codecov Report

Merging #1433 into 2.7.x-release will decrease coverage by <.01%.
The diff coverage is 0%.

@@               Coverage Diff                @@
##           2.7.x-release   #1433      +/-   ##
================================================
- Coverage           3.31%    3.3%   -0.01%     
================================================
  Files                128     128              
  Lines               6814    6828      +14     
  Branches             667     668       +1     
================================================
  Hits                 226     226              
- Misses              6573    6587      +14     
  Partials              15      15

Impacted Files	Coverage Δ
...n/java/fr/free/nrw/commons/auth/LoginActivity.java	0% <0%> (ø)	⬆️
.../java/fr/free/nrw/commons/auth/SessionManager.java	14.63% <0%> (-2.51%)	⬇️
...ommons/modifications/ModificationsSyncAdapter.java	0% <0%> (ø)	⬆️
...r/free/nrw/commons/auth/AuthenticatedActivity.java	0% <0%> (ø)	⬆️
...rw/commons/mwapi/ApacheHttpClientMediaWikiApi.java	5.43% <0%> (-0.06%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 802b2a8...0c97249. Read the comment docs.

[misaochan]

Tested on API 25 emulator. This works well for me, although I haven't been able to reproduce the bug reliably. @neslihanturan if this succeeds in your tests as well, please feel free to go ahead and merge. :)

[neslihanturan]

Happily, I was able to reproduce this bug reliably. With this technique:

• First run 2.6.7-release branch on a device
• Probably it will require log in, so log in
• Then, run 2.7.x-release branch on same branch

When it comes to this PR, after the bug this changes brings us a black screen and a very fast repetitive log. Seems like there is a endless loop or confusion in the code:
04-11 15:50:54.702 3234-3234/fr.free.nrw.commons.debug E/SessionManager: User is not logged in 04-11 15:50:54.732 3234-3234/fr.free.nrw.commons.debug D/EGL_emulation: eglMakeCurrent: 0xb90bf7e0: ver 2 0 04-11 15:50:54.732 3234-3234/fr.free.nrw.commons.debug E/EGL_emulation: tid 3234: eglSurfaceAttrib(1199): error 0x3009 (EGL_BAD_MATCH) 04-11 15:50:54.732 3234-3234/fr.free.nrw.commons.debug W/HardwareRenderer: Backbuffer cannot be preserved 04-11 15:50:54.752 3234-3234/fr.free.nrw.commons.debug W/PathParser: Points are too far apart 4.000000596046461 04-11 15:50:54.792 3234-3234/fr.free.nrw.commons.debug D/EGL_emulation: eglMakeCurrent: 0xb90bf7e0: ver 2 0 04-11 15:50:54.812 3234-3234/fr.free.nrw.commons.debug D/EGL_emulation: eglMakeCurrent: 0xb90bf7e0: ver 2 0 04-11 15:50:54.832 3234-3234/fr.free.nrw.commons.debug I/AppCompatViewInflater: app:theme is now deprecated. Please move to using android:theme instead. 04-11 15:50:54.842 3234-3234/fr.free.nrw.commons.debug D/ContributionsListFragme: Last Sync Timestamp: 2018-04-11T12:44:52Z 04-11 15:50:54.842 3234-3234/fr.free.nrw.commons.debug E/SessionManager: User is not logged in User is not logged in

User is not logged in part can be important I guess

[maskaravivek]

Have opened another PR(#1454 ) to fix this issue. So closing this one.