Fix blank categories in direct Nearby uploads #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into 2.7.x-release-fork
… into 2.7.x-release-fork
… into 2.7.x-release-fork
…s-android-commons into 2.7.x-release-fork
… into 2.7.x-release-fork
… able to see real Commons categories)
15 tasks
Codecov Report
@@ Coverage Diff @@
## 2.7.x-release #1426 +/- ##
================================================
- Coverage 3.31% 3.31% -0.01%
================================================
Files 128 128
Lines 6809 6810 +1
Branches 669 669
================================================
Hits 226 226
- Misses 6568 6569 +1
Partials 15 15
Continue to review full report at Codecov.
|
|
Worked for me @misaochan , thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1418
To test, upload to an item in Nearby list or map that doesn't have Commons categories. No blank category should be shown in category selection screen.
Tested with Nexus S API 25