-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hot fix bundle issue #1425
Hot fix bundle issue #1425
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.7.x-release #1425 +/- ##
================================================
- Coverage 3.31% 3.31% -0.01%
================================================
Files 128 128
Lines 6809 6810 +1
Branches 669 667 -2
================================================
Hits 226 226
- Misses 6568 6569 +1
Partials 15 15
Continue to review full report at Codecov.
|
@97balakrishnan Are you able to test this PR and see if it resolves the issue for you? If not, I will test and merge it, but I haven't been able to reproduce the bug either so I will just be testing that it doesn't impair functionality. |
Unable to reproduce the bug either, but functionality still works well for me, so will go ahead and merge. Thanks @neslihanturan . :) |
@misaochan Didn't notice the PR was already there for issue, although I was able to reproduce the issue on my phone and have a solution which involves just 6 lines changes. Should I create a PR for it? |
@knight-shade Could you please check if it still happens for you in the 2.7.x-release branch? If it does then yes, please do. :) |
Yes @misaochan I tested in 2.7.x-release branch, app is not crashing. 🙂 |
@knight-shade Ah, okay. Yeah, I need to push the 2.7.x-release branch changes to master, will do that shortly. :) But if the former isn't crashing for you, no need for the PR I believe. If you are looking for something to work on, maybe consider #1412 or #1419 ? |
Description
Fixes #1416
Sending bundles from fragment to activity handled with a method instead of setBundle method, since it is illegal to call setBundle method on an already created fragment. I couldnt reproduce the bug but, this should solve the issue.
Tests performed
Tested on API 19, manual test