Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot fix bundle issue #1425

Merged
merged 7 commits into from
Apr 8, 2018
Merged

Hot fix bundle issue #1425

merged 7 commits into from
Apr 8, 2018

Conversation

neslihanturan
Copy link
Collaborator

Description

Fixes #1416
Sending bundles from fragment to activity handled with a method instead of setBundle method, since it is illegal to call setBundle method on an already created fragment. I couldnt reproduce the bug but, this should solve the issue.

Tests performed

Tested on API 19, manual test

@codecov-io
Copy link

Codecov Report

Merging #1425 into 2.7.x-release will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff                @@
##           2.7.x-release   #1425      +/-   ##
================================================
- Coverage           3.31%   3.31%   -0.01%     
================================================
  Files                128     128              
  Lines               6809    6810       +1     
  Branches             669     667       -2     
================================================
  Hits                 226     226              
- Misses              6568    6569       +1     
  Partials              15      15
Impacted Files Coverage Δ
.../fr/free/nrw/commons/nearby/NearbyMapFragment.java 0% <0%> (ø) ⬆️
...fr/free/nrw/commons/nearby/NearbyListFragment.java 0% <0%> (ø) ⬆️
...ava/fr/free/nrw/commons/nearby/NearbyActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2150d7f...e8da61b. Read the comment docs.

@misaochan
Copy link
Member

@97balakrishnan Are you able to test this PR and see if it resolves the issue for you? If not, I will test and merge it, but I haven't been able to reproduce the bug either so I will just be testing that it doesn't impair functionality.

@misaochan
Copy link
Member

Unable to reproduce the bug either, but functionality still works well for me, so will go ahead and merge. Thanks @neslihanturan . :)

@misaochan misaochan merged commit 802b2a8 into 2.7.x-release Apr 8, 2018
@misaochan misaochan deleted the hotFixBundleIssue branch April 8, 2018 09:17
@knight-shade
Copy link
Contributor

@misaochan Didn't notice the PR was already there for issue, although I was able to reproduce the issue on my phone and have a solution which involves just 6 lines changes. Should I create a PR for it?

@misaochan
Copy link
Member

@knight-shade Could you please check if it still happens for you in the 2.7.x-release branch? If it does then yes, please do. :)

@knight-shade
Copy link
Contributor

Yes @misaochan I tested in 2.7.x-release branch, app is not crashing. 🙂
But its crashing in master branch.

@misaochan
Copy link
Member

@knight-shade Ah, okay. Yeah, I need to push the 2.7.x-release branch changes to master, will do that shortly. :) But if the former isn't crashing for you, no need for the PR I believe.

If you are looking for something to work on, maybe consider #1412 or #1419 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants