Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update makedoc using mistune v3 #787

Merged
merged 9 commits into from
Jan 18, 2024

Conversation

fmigneault
Copy link
Contributor

Fixes #721
Requires lepture/mistune#375

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmigneault I copied in the stubs from the mistune PR for now, so we don't have to wait on the new release.

Can you look into the test failures?

@fmigneault
Copy link
Contributor Author

fmigneault commented Jan 18, 2024

@mr-c
One of the failing test is test_multiline_list_entries_without_indention where the expected <li></li> tags are instead represented by <ul></ul>. If this is acceptable, we can simply replace the test string.
Nevermind, it is only a diff about how newlines are applied. I will adjust the test.

The other is the checksum comparison that must be updated if we are satisfied with the new output format.

@mr-c mr-c enabled auto-merge (squash) January 18, 2024 15:24
@mr-c mr-c merged commit eb6f94f into common-workflow-language:main Jan 18, 2024
41 checks passed
@mr-c
Copy link
Member

mr-c commented Jan 18, 2024

Thank you @fmigneault !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade mistune to v3
2 participants