podman driver changes #1343
Closed
podman driver changes #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use podman, the following changes are required. However, these changes are not docker compatible so there is a need for a maintainable way to support the different flags/arguments required for different drivers
mr-c
reviewed
Sep 28, 2020
| @@ -392,7 +392,7 @@ def create_runtime( | |||
| runtime.append("--net=none") | |||
|
|
|||
| if self.stdout is not None: | |||
| runtime.append("--log-driver=none") | |||
| runtime.append("--log-driver=k8s-file") | |||
There was a problem hiding this comment.
I'd accept a flag and/or auto detection for this one
|
I have since tested podman 2.x with cwltool and found that they have made podman command line options more compatible with docker. Hence, this pull request is redundant. |
|
@nyue Good news, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use podman, the following changes are required.
However, these changes are not docker compatible
so there is a need for a maintainable way to support
the different flags/arguments required for different
drivers