Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open the common fate console #732

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Conversation

JoshuaWilkes
Copy link
Contributor

What changed?

Adds granted cf which can be used to launch the Common Fate console from the cli.
It first tries to detect a console url from the aws config, if more than one is found, a select is shown.
If none is found in the profiles, falls back to the cf config file.

a --profile flag can be used to open the console for5 a specific profile

Why?

convenient way to get to the console to make a request using the web when needed

How did you test it?

Tested with more then one console URL in my config

Potential risks

This does not respect any custom browser configuration

Is patch release candidate?

Link to relevant docs PRs

Copy link
Contributor

@chrnorm chrnorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking cf may not be self-explanatory that it is going to open a browser window, what about granted web open instead?

(ideally we'd have something like granted console open, however we already use granted console for the AWS console)

@JoshuaWilkes JoshuaWilkes merged commit f0cf2fe into main Aug 15, 2024
2 of 3 checks passed
@JoshuaWilkes JoshuaWilkes deleted the Open-the-Common-Fate-console branch August 15, 2024 07:12
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Sep 23, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [common-fate/granted](https://github.com/common-fate/granted) | minor | `v0.32.0` -> `v0.33.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>common-fate/granted (common-fate/granted)</summary>

### [`v0.33.0`](https://github.com/common-fate/granted/releases/tag/v0.33.0)

[Compare Source](common-fate/granted@v0.32.0...v0.33.0)

This release adds [support for XDG directories](common-fate/granted#726) (thankyou [@&#8203;chris3ware](https://github.com/chris3ware)!), and adds a new `granted request close` command for closing Just-In-Time Access Requests in Common Fate.

#### What's Changed

-   if we run into the issue with activation, print the diagnostics by [@&#8203;meyerjrr](https://github.com/meyerjrr) in common-fate/granted#734
-   Open the common fate console by [@&#8203;JoshuaWilkes](https://github.com/JoshuaWilkes) in common-fate/granted#732
-   Add support for custom browser launch templates by [@&#8203;chrnorm](https://github.com/chrnorm) in common-fate/granted#731
-   Add messaging when the proxy command cannot connect to the target in SSM by [@&#8203;JoshuaWilkes](https://github.com/JoshuaWilkes) in common-fate/granted#735
-   Add support for XDG directories by [@&#8203;chris3ware](https://github.com/chris3ware) in common-fate/granted#726
-   Add 'granted request close' subcommand by [@&#8203;ckluy31](https://github.com/ckluy31) in common-fate/granted#740
-   Fix success message when access request is closed by [@&#8203;ckluy31](https://github.com/ckluy31) in common-fate/granted#743
-   Fix nil pointer error in registry sync when merging fails with an unknown error by [@&#8203;JoshuaWilkes](https://github.com/JoshuaWilkes) in common-fate/granted#744
-   Granted login deprecation message should be clearer by [@&#8203;ckluy31](https://github.com/ckluy31) in common-fate/granted#745

#### New Contributors

-   [@&#8203;chris3ware](https://github.com/chris3ware) made their first contribution in common-fate/granted#726

**Full Changelog**: common-fate/granted@v0.32.0...v0.33.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants