-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A lot of unnecessary files are included in the npm package #730
Comments
andrewhampton
added a commit
to andrewhampton/cz-cli
that referenced
this issue
Sep 30, 2021
I noticed in a PR review for a bump from 4.2.3 to 4.2.4 that there were [810 changed files][1]. One was packages.json, the other 809 were .nyc_output json files. This makes it particularly tough to do a thorough security review. [1]: https://app.renovatebot.com/package-diff?name=commitizen&from=4.2.3&to=4.2.4#d2h-425221 fixes commitizen#730
I ran across this today when I saw renovate's diff of the published files comparing 4.2.3 to 4.2.4. The fix seemed simple enough, so I opened #851 to address this issue. |
LinusU
pushed a commit
that referenced
this issue
Nov 8, 2021
I noticed in a PR review for a bump from 4.2.3 to 4.2.4 that there were [810 changed files][1]. One was packages.json, the other 809 were .nyc_output json files. This makes it particularly tough to do a thorough security review. [1]: https://app.renovatebot.com/package-diff?name=commitizen&from=4.2.3&to=4.2.4#d2h-425221 fixes #730
🎉 This issue has been resolved in version 4.2.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From the last Travis log:
The text was updated successfully, but these errors were encountered: