Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--file-watch should respect VCS boring/ignore files #831

Merged
merged 1 commit into from
Aug 23, 2015

Conversation

agrafix
Copy link
Contributor

@agrafix agrafix commented Aug 22, 2015

( A first attempt of Part 1 for #703 )

This is a very basic implementation and I've moved out most of the logic to a separate package ( http://hackage.haskell.org/package/ignore ) as I would like to reuse it for other projects. Don't know if this is the desired approach, looking for feedback :-)

@snoyberg snoyberg merged commit f664843 into commercialhaskell:master Aug 23, 2015
@snoyberg
Copy link
Contributor

Thanks!

@luigy
Copy link
Contributor

luigy commented Aug 23, 2015

One of ignore's dependencies requires having pcre headers installed
I had to install them through my package manager first on OS X 10.10... I thought they would come with Xcode :/

@agrafix
Copy link
Contributor Author

agrafix commented Aug 23, 2015

Yeah, to correctly interpret mercurials hgignore files you need pcre :-(

@snoyberg
Copy link
Contributor

Hmm, that's actually a serious problem, since it will greatly complicate
the windows installation story. Is there any subset of functionality we can
get without the library dependency?

On Sun, Aug 23, 2015, 6:55 PM Alexander Thiemann [email protected]
wrote:

Yeah, to correctly interpret mercurials hgignore files you need pcre :-(


Reply to this email directly or view it on GitHub
#831 (comment)
.

@agrafix
Copy link
Contributor Author

agrafix commented Aug 23, 2015

The simplest thing would probably be to add a flag to the ignore package to build w/o pcre and then use that on windows. .gitignore files will still work fine as the run on globs, but .hgignore files will only work with syntax: glob enabled. Would that be a solution?

@snoyberg
Copy link
Contributor

It's a little awkward to provide different functionality by OS. And this
may be a problem on Mac as well, I'm not sure. Purely from the ease of
install perspective, my answer would be to fully drop mercurial support,
but that's not a great answer either.

On Sun, Aug 23, 2015, 8:01 PM Alexander Thiemann [email protected]
wrote:

The simplest thing would probably be to add a flag to the ignore package
to build w/o pcre and then use that on windows. .gitignore files will still
work fine as the run on globs, but .hgignore files will only work with syntax:
glob enabled. Would that be a solution?


Reply to this email directly or view it on GitHub
#831 (comment)
.

@borsboom
Copy link
Contributor

It's not ideal on Linux either (I just had to install libpcre on a system for the latest version of stack).

@agrafix
Copy link
Contributor Author

agrafix commented Aug 23, 2015

I'll add a flag to the ignore package to remove pcre support for now as a quick fix, and then we can look for a long term fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants