Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repl for test components #5306

Merged
merged 1 commit into from
Jun 21, 2020
Merged

Conversation

qrilka
Copy link
Contributor

@qrilka qrilka commented May 28, 2020

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Tested using https://github.com/fduxiao/mal taken from haskell/haskell-ide-engine#1564

It's not quite clear why stack-head repl mal:exe:mal-exe doesn't work. I have a suspicion that we could need component-based builds but I didn't investigate it deeper.

@qrilka qrilka changed the base branch from master to stable May 28, 2020 21:36
@qrilka
Copy link
Contributor Author

qrilka commented May 28, 2020

Fixes the problem with test components from #5213

Copy link
Contributor

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Feel free to merge when ready. Would you mind adding a ChangeLog entry as well?

@qrilka
Copy link
Contributor Author

qrilka commented Jun 14, 2020

The main concern that I have is the partiality of this fix, I'll add a changlog entry and merge but also will take another turn next week and try to understand the reasons this doesn't work for executable targets.
Thank you

This partially fixes #5213 - starting a repl for an exe component
doesn't appear to work for some reason
@qrilka qrilka force-pushed the 5213-fix-repl-for-test-components branch from a699e4f to 88aaf59 Compare June 17, 2020 21:31
@qrilka
Copy link
Contributor Author

qrilka commented Jun 17, 2020

I've added a changelog but and as we've discussed fixing the problem for executables doesn't look easy.
@snoyberg I have a question still - I targeted this PR to stable - will we have a minor release which it could go into?

@snoyberg
Copy link
Contributor

We definitely can make a minor release, but there isn't one currently planned

@qrilka
Copy link
Contributor Author

qrilka commented Jun 18, 2020

@psibi maybe you know what could be producing The AWS Access Key Id you provided does not exist in our records. in the failed CI jobs for this PR?

@psibi
Copy link
Member

psibi commented Jun 18, 2020

@qrilka Sorry, no idea. Do you know how long this has been failing ?

@qrilka
Copy link
Contributor Author

qrilka commented Jun 18, 2020

It's the first time I see something like this

@qrilka
Copy link
Contributor Author

qrilka commented Jun 18, 2020

Restarting the pipelines doesn't change anything, @borsboom do you know if we did any changes to AWS config lately? It looks like cache-s3 can't access the corresponding bucket...

@snoyberg
Copy link
Contributor

I've been meaning to move us over to Github Actions instead of Azure CI for a few months now, this looks like a good kick in the pants to actually do it.

@qrilka
Copy link
Contributor Author

qrilka commented Jun 21, 2020

@snoyberg it looks like the problem is only about cache-s3 bucket and other steps look to be fine, do you think we could merge it?

@snoyberg
Copy link
Contributor

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants