-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix repl for test components #5306
Conversation
Fixes the problem with test components from #5213 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Feel free to merge when ready. Would you mind adding a ChangeLog entry as well?
The main concern that I have is the partiality of this fix, I'll add a changlog entry and merge but also will take another turn next week and try to understand the reasons this doesn't work for executable targets. |
This partially fixes #5213 - starting a repl for an exe component doesn't appear to work for some reason
a699e4f
to
88aaf59
Compare
I've added a changelog but and as we've discussed fixing the problem for executables doesn't look easy. |
We definitely can make a minor release, but there isn't one currently planned |
@psibi maybe you know what could be producing |
@qrilka Sorry, no idea. Do you know how long this has been failing ? |
It's the first time I see something like this |
Restarting the pipelines doesn't change anything, @borsboom do you know if we did any changes to AWS config lately? It looks like cache-s3 can't access the corresponding bucket... |
I've been meaning to move us over to Github Actions instead of Azure CI for a few months now, this looks like a good kick in the pants to actually do it. |
@snoyberg it looks like the problem is only about cache-s3 bucket and other steps look to be fine, do you think we could merge it? |
Sounds good |
Please include the following checklist in your PR:
Tested using https://github.com/fduxiao/mal taken from haskell/haskell-ide-engine#1564
It's not quite clear why
stack-head repl mal:exe:mal-exe
doesn't work. I have a suspicion that we could need component-based builds but I didn't investigate it deeper.