Setup-info configurability #5031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoyberg
reviewed
Nov 7, 2019
doc/yaml_configuration.md
Outdated
| If you need to **replace** it, use the `stack --setup-info-yaml` command-line | ||
| argument instead. The default setup metadata is in | ||
| [stack-setup-2.yaml](https://github.com/commercialhaskell/stackage-content/raw/master/stack/stack-setup-2.yaml). | ||
| Note that specifying this config *does not* the default `stack-setup-2.yaml` from being consulted as a fallback. |
There was a problem hiding this comment.
I think there's a typo in this sentence, I'm not sure how it's supposed to read.
src/Stack/Options/ConfigParser.hs
Outdated
| <*> many ( | ||
| strOption | ||
| ( long "setup-info-yaml" | ||
| <> help "Alternate URL or absolute path for stack dependencies" |
There was a problem hiding this comment.
I would think a relative path would be even more convenient and recommended, so that the YAML file can be included in a repo and the code will work on multiple machines. Any underlying reason for preferring absolute paths?
…yaml as top level CmdArg
…efault if none specified.
|
@snoyberg There are 2 outstanding issues which are out-of-scope for the current PR and should be handled seperately:
|
|
Also, feel free to re-arrange the change-log, I had no clue which sections the changes should be in. |
snoyberg
approved these changes
Nov 24, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes to fix various issues related to how
stackdecides where to resolves it's tooling locations, for the initial purpose of usingstackoffline or behind a firewall.Stack 2 broke the previous behavior of the
setup-infofield - which now does not overwrite the default location. #2983, #2913This existing breakage allowed for a backwards-compatible implementation of the wanted behavior - via the
setup-info-locationsyaml config for remote locations, and usingsetup-infofor inline configuration only.Also, as the
--stack-setup-yamlCmdArg has been deprecated for 3 years, it is now removed, in favor of--setup-info-yaml#2647Design decisions:
stack-setup-2.yamlis added to thesetup-info-locationsonly if no locations were specified (either in the cmd args or in the config yaml)PR considerations:
setup-info, command line args,setup-info-locationsand the default location, with missing / invalid locations to check that no unwanted accesses are made.Relevant issues:
stack setupshould not fail if it couldn't download default stack-setup-yamlSetupInfoConsider if other order of combination is more appropriate for the monoids on config typesstack setup --stack-setup-yamloptionthough.