Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning about local-programs-path with spaces on windows when running scripts #5013

Merged
merged 4 commits into from
Aug 30, 2019
Merged

Show warning about local-programs-path with spaces on windows when running scripts #5013

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67d90ec
Change log level to show it running scripts
jneira Aug 20, 2019
d99c477
Update Changelog
jneira Aug 20, 2019
0934be9
Fix typo as suggested by @dbaynard
jneira Aug 21, 2019
0937c8e
Show original local-programs-path
jneira Aug 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ Behavior changes:

Other enhancements:

* Show warning about `local-programs-path` with spaces on windows
when running scripts. See
[#5013](https://github.com/commercialhaskell/stack/pull/5013)

* Add `ls dependencies json` which will print dependencies as JSON.
`ls dependencies --tree` is now `ls dependencies tree`. See
[#4424](https://github.com/commercialhaskell/stack/pull/4424)
Expand Down
2 changes: 1 addition & 1 deletion src/Stack/Config.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ configFromConfigMonoid
shortLocalProgramsFilePath <-
liftIO $ getShortPathName localProgramsFilePath
when (' ' `elem` shortLocalProgramsFilePath) $ do
logWarn $ "Stack's 'programs' path contains a space character and " <>
logError $ "Stack's 'programs' path contains a space character and " <>
"has no alternative short ('8 dot 3') name. This will cause " <>
"problems with packages that use the GNU project's 'configure' " <>
"shell script. Use the 'local-programs-path' configuation option " <>
jneira marked this conversation as resolved.
Show resolved Hide resolved
Expand Down