Get package name from completed information #4789 #4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The completed package information already contains the package name, bypassing the need for a package completion call if the cache (lock file) already contains that information. This bypasses a spurious warning about lacking cryptographic hashes, and likely improves performance, for the repo and archive cases. This wasn't discovered initially because the Hackage use case never had an overhead: the specification of a RPLIHackage already contains the package name in all cases.
qrilka
reviewed
May 6, 2019
| pliIdent :: PackageLocationImmutable -> PackageIdentifier | ||
| pliIdent (PLIHackage ident _ _) = ident | ||
| pliIdent (PLIArchive _ pm) = pmIdent pm | ||
| pliIdent (PLIRepo _ pm) = pmIdent pm |
There was a problem hiding this comment.
@snoyberg there's already packageLocationIdent -
stack/subs/pantry/src/Pantry.hs
Line 1337 in 38826df
There was a problem hiding this comment.
Doh, thanks. I'll send a PR to fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The completed package information already contains the package name,
bypassing the need for a package completion call if the cache (lock
file) already contains that information. This bypasses a spurious
warning about lacking cryptographic hashes, and likely improves
performance, for the repo and archive cases.
This wasn't discovered initially because the Hackage use case never had
an overhead: the specification of a RPLIHackage already contains the
package name in all cases.