Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect cabal spec version (fixes #4488) #4691

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Respect cabal spec version (fixes #4488) #4691

merged 1 commit into from
Apr 3, 2019

Conversation

snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Apr 3, 2019

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

@snoyberg snoyberg mentioned this pull request Apr 3, 2019
Closed
@snoyberg snoyberg requested a review from qrilka April 3, 2019 11:04
vrom911
vrom911 approved these changes Apr 3, 2019
View reviewed changes
Copy link

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! This is so useful! 👍

@snoyberg snoyberg merged commit ef19b4a into master Apr 3, 2019
@snoyberg snoyberg deleted the 4488-respect-cabal-spec-version branch April 3, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrom911 vrom911 vrom911 approved these changes

@qrilka qrilka qrilka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snoyberg @qrilka @vrom911