Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the config env command (fixes #620) #4642

Merged
merged 3 commits into from
Mar 24, 2019
Merged

Add the config env command (fixes #620) #4642

merged 3 commits into from
Mar 24, 2019

Conversation

snoyberg
Copy link
Contributor

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

New integration test added.

@sjakobi
Copy link
Member

sjakobi commented Mar 20, 2019

@snoyberg This looks useful! :)

I'm wondering though whether the stack config namespace is the right place for this functionality:

≻ stack exec -- stack config --help
Usage: stack config COMMAND [--help]
  Subcommands specific to modifying stack.yaml files

Available options:
  --help                   Show this help text

Available commands:
  set                      Sets a field in the project's stack.yaml to value
  env                      Print environment variables for use in a shell

Run 'stack --help' for global options that apply to all subcommands.

But it might be enough to change the line Subcommands specific to modifying stack.yaml files.

@snoyberg
Copy link
Contributor Author

I was also unsure of using config, I'm glad you raised it. My decision came from the fact that the original issue mentioned that namespace from other tooling, so it seemed consistent. I'm happy to either give this a different name or fix the help text. If I don't hear from others, I'll go the direction of changing the help text.

@snoyberg snoyberg merged commit 6a5540a into master Mar 24, 2019
@snoyberg snoyberg deleted the 620-env-command branch March 24, 2019 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants