Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get-stack work on Windows CI systems #4555

Merged
merged 4 commits into from
Feb 6, 2019

Conversation

ndmitchell
Copy link
Contributor

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

I tested the changes by creating https://github.com/ndmitchell/ci-check/ to check all CI systems and also on Azure Mac/Windows/Linux.

@borsboom
Copy link
Contributor

borsboom commented Feb 6, 2019

Looks good. There's a conflict in the ChangeLog but once that's resolved I'll merge.

@ndmitchell
Copy link
Contributor Author

Merge fixed @borsboom

@borsboom borsboom merged commit a7b07fc into commercialhaskell:master Feb 6, 2019
@ndmitchell
Copy link
Contributor Author

Thanks! Any chance of deploying the updated script to the https://get.haskellstack.org now? It means I could simplify my CI scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants