Fix #4183 Make PrettyPrint styles background-agnostic #4203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to ensure sufficient contrast on both black (dull black) and white (vivid white) terminals, also changes foreground text `bold . white` to `dullcyan` (affecting `styleFile` and `styleUrl`) and `yellow` to `dullyellow` (affecting `styleWarning` and `styleCurrent`). `dullcyan` is used in preference to `black` (vivid black) because the latter is problematic with the solarised dark theme. See also issue commercialhaskell#4047 and (reverted) commercialhaskell#4814.
mihaimaruseac
approved these changes
Aug 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to ensure sufficient contrast on both black (dull black) and white (vivid white) terminals, also changes foreground text
bold . whitetodullcyan(affectingstyleFileandstyleUrl) andyellowtodullyellow(affectingstyleWarningandstyleCurrent).dullcyanis used in preference toblack(vivid black) because the latter is problematic with the popular 'solarized dark' theme.See also issue #4047 and (reverted) #4814.
Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!
See #4183 for screen shots of stack operating after this pull request is implemented.