Do not discard package location #3714

[snoyberg]

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

• Any changes that could be relevant to users have been recorded in the ChangeLog.md
• The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

[mgsloan]

LGTM! Lets see if I understand this, though:

splitUnmetDeps is used for both packages in the global DB and packages in the snapshot. For the packages in the global DB, it needs to convert them to snapshot packages. For the packages in the snapshot, they should remain snapshot packages. Hence, pulling globalToSnapshot out of splitUnmetDeps and using it in only one case.

[snoyberg]

Almost exactly correct. There are two stages to calling splitUnmetDeps on the snapshot packages. The second time around it's adding in local packages, so I'm that case the snapshot packages graduate to local packages.

[mgsloan]

I see, thanks!