Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try the mkdocs search hack #3379

Closed
wants to merge 4 commits into from
Closed

Try the mkdocs search hack #3379

wants to merge 4 commits into from

Conversation

decentral1se
Copy link
Member

Something for #3376.

Unfortunately, I couldn't test this (because mkdocs search actually works locally). For someone who has access to the RTD builder, I think you can build off a branch and view the documentation. Then just try to search something and see if you get the mkdocs search bar and not the broken RTD one.

\cc @mgsloan @borsboom

@@ -0,0 +1,29 @@
// Please see https://github.com/commercialhaskell/stack/issues/3376

(function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it, but it looks to me like this function won't be run, needs another () on the last line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, you're right. I should have listened to my JavaScript linter ;)

@borsboom
Copy link
Contributor

@lwm I've copied your fixup-search branch to the main repo, and told readthedocs to build it. Unfortunately, all documentation builds seem to be failing for the last day with "An unexpected error occurred", so we can't actually test it yet. You should be able to push changes to the fixup-search branch yourself too.

@decentral1se
Copy link
Member Author

decentral1se commented Aug 23, 2017

all documentation builds seem to be failing for the last day with "An unexpected error occurred"

Hmm, seems like the RTD build needs some attention then. Any stack trace?

Feel like adding me to the RTD account so I can play around with it or?

(I pushed my fixups to the upstream branch as well in case the error is resolved).

@borsboom
Copy link
Contributor

RTD seems to be failing most builds, but occasionally passing. I've made lwm a maintainer there.

@decentral1se
Copy link
Member Author

Ugh, seems to be a bunch of these 'unexpected error' messages plaguing people, as far as I can see in readthedocs/readthedocs.org#2985. I'll keep an eye there but can't seem to get any good of it now.

@decentral1se decentral1se self-assigned this Aug 24, 2017
@decentral1se
Copy link
Member Author

I'll close this off for now and try to fix when things are clear on the RTD side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants