Mention apt-get update for Ubuntu #2909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If system package installation fails, stack should not be installed.
borsboom
requested changes
Jan 10, 2017
| date. Resolved [#781](https://github.com/commercialhaskell/stack/issues/781) | ||
| * Respects the `custom-setup` field introduced in Cabal 1.24. This | ||
| supercedes any `explicit-setup-deps` settings in your `stack.yaml` | ||
| and trusts the package's `.cabal` file to explicitly state all its | ||
| dependencies. | ||
| * If system package installation fails, `stack` won't be installed. Also shows a |
There was a problem hiding this comment.
Can you make it clear that this applies to get-stack.sh / https://get.haskellstack.org, and not the stack command itself?
borsboom
approved these changes
Jan 10, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2898
If system package installation fails, stack should not be installed.
I've tried running a new Ubuntu 16.04 EC2 instance, it behaves as expected: fails at first, after
apt-get updateinstalls stack properly.