Don't treat local extra-dep packages as targets #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The immediate problem I noticed was that, when running `stack build` with two local packages, one an extra-dep, the build output was not sent to the console. This fixes the problem, but I believe there's still an issue with the test suite being spuriously run. Still investigating that.
This logic works, but arguably is not being handled very elegantly. I see two alternatives: * Do a more serious refactoring to unify Hackage extra-deps and local extra-dep values * In the `case mtarget`, add `_ | lpvExtraDep lpv -> mempty`. I tried this at first, but I believe the behavior was slightly confusing, since running `stack build :test-suite-name` for a local extra-dep didn't run the test. However, that may in fact be the desired behavior. This and the previous commit appear to fix #2545
|
Anecdotally (just tested with Snowdrift), this fixes #1295. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The immediate problem I noticed was that, when running
stack buildwith two local packages, one an extra-dep, the build output was not sent
to the console. This fixes the problem, but I believe there's still an
issue with the test suite being spuriously run. Still investigating
that.