-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nix-shell no longer called with a GHC from an LTS mirror #2270
Conversation
Ok, actually it did work because I already had in my |
It's fixed now. I've tried it with several resolvers, both lts and fixed ghc versions. |
3a54ab0
to
b8ad2a0
Compare
The CI error on OSX is rather weird, I'm getting right from the beginning of a fresh build:
However on my machine, on OSX, the build succeeds and |
I think I've seen the "ghc not found in path" error before. Some travis nondeterminism of some variety :/ The git sha thing isn't cause for concern, and is tracked by #2175 |
@mgsloan anything holding back the merge of this PR? Now that LTS snapshots have been removed from Nixpkgs, Stack --nix users are pretty stuck without this PR. |
We retrieve the right GHC version before calling Nix.reexecWithOptionalShell
Changelog updated too
@YPares branch force pushed to resolve conflicts. |
As explained in #2259
we will soon no longer be able to give to nix-shell indentifiers like
haskell.packages.lts-5_14.ghc
since LTS mirroring will be removed from the Nixpkgs.
This PR proposes to retrieve the wanted GHC version before creating the nix shell, which will now
always be called with derivations like
haskell.compiler.ghc7103
.Until the lts mirroring is removed from Nix, this also provides the advantage that now you don't have to pay attention to which LTS you use into your
stack.yaml