Pretty printer + improved plan construction errors #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Just (_, parents) -> map (\(pkgId, _) -> (packageIdentifierName pkgId, extendDepsPath pkgId dp)) parents | ||
|
|
||
| data DepsPath = DepsPath Int Int [PackageIdentifier] | ||
| deriving (Eq, Ord, Show) |
There was a problem hiding this comment.
I think this type could be improved with record syntax and/or a comment.
|
Awesome stuff! This will fix #1739 too! |
| @@ -731,7 +749,8 @@ pprintExceptions exceptions stackYaml = | |||
| vsep (map pprintExtra (Map.toList extras)) <> | |||
| line <> | |||
| line <> | |||
| "You may also want to try the 'stack solver' command" <> line <> line | |||
| "You may also want to try the 'stack solver' command" <> line <> line <> | |||
| fromString (show parentMap) | |||
There was a problem hiding this comment.
The debug output here should be removed eventually.
|
Also, the line wrapping could be a bit cleaner IMO. Currently, readability at both 80 and 100 columns isn't that great. (Much better than before anyway, of course! :D) 80 columns: 100 columns: I'd prefer the output to be optimized for 80 columns but clean output at 100 columns would make me happy, too! ;) |
mgsloan
added a commit
that referenced
this pull request
Aug 6, 2016
Pretty printer + improved plan construction errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when you select the wrong version of a package that a lot of things depend on, you can get gobs and gobs of output. For example, setting
containers-0.3.0.0breaks pretty much every package in the build plan and you get hundreds of lines of output: https://gist.github.com/mgsloan/2a93bc5282f38d9b337e9571dbc8611aI've omitted info about which specific inter-package dependencies have failed. Instead, it tells you the root problem with color-coded info
The "needed due to" path gives the shortest path from a target to the package. Hopefully it's clear that this is not necessarily the only path (in this case, just one of many)