Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust -i paths used by ghci to point to autogen / etc files generated by newer Cabal #3791

Closed
mgsloan opened this issue Jan 18, 2018 · 5 comments
Closed

Adjust -i paths used by ghci to point to autogen / etc files generated by newer Cabal #3791

mgsloan opened this issue Jan 18, 2018 · 5 comments
Labels
component: ghci type: bug
Milestone
P0: Blocking release

Comments

@mgsloan
Copy link
Contributor

mgsloan commented Jan 18, 2018

I think this change was introduced in Cabal >= 2. stack ghci currently adds dist/build/autogen and similar dirs to the source search path. Cabal's per component build instead puts them in dist/build/$COMPONENT/autogen.
@mgsloan mgsloan added this to the P0: Blocking release milestone Jan 18, 2018
@gahag gahag mentioned this issue Jan 20, 2018
Closed
@gahag
Copy link

gahag commented Jan 20, 2018

This also affects flycheck for emacs. It reports it can't find autogen modules, as stack ghci does. Downgrading the resolver from lts-10.3 to lts-9.21 seems to be a temporary solution.

gahag added a commit to gahag/FSQL that referenced this issue Jan 20, 2018
@gahag
Downgraded resolver due to bug in the latest version of stack.
7222617 
The latest version of stack has a small incompatibility with the
latest version of cabal.
Refer to commercialhaskell/stack#3791
mgsloan added a commit that referenced this issue Jan 20, 2018
@mgsloan
Use per-component build directories for ghci with Cabal>=2.0 #3791
91525f1
@mgsloan
Copy link
Contributor Author

mgsloan commented Jan 20, 2018

@gahag I've opened a PR which fixes this - #3795

mgsloan added a commit that referenced this issue Jan 20, 2018
@mgsloan
Use per-component build directories for ghci with Cabal>=2.0 #3791
9c94d41
mgsloan added a commit that referenced this issue Jan 20, 2018
@mgsloan
Use per-component build directories for ghci with Cabal>=2.0 #3791
c891c96
sergv added a commit to sergv/flycheck-haskell that referenced this issue Jan 22, 2018
@sergv
Work around changed behaviour of Cabal 2 w.r.t. autogen dirs
46d04b4 
Cf flycheck#82, commercialhaskell/stack#3791
mgsloan added a commit that referenced this issue Feb 11, 2018
@mgsloan
Use per-component build directories for ghci with Cabal>=2.0 #3791
3169daf
mgsloan added a commit that referenced this issue Feb 18, 2018
@mgsloan
Use per-component build directories for ghci with Cabal>=2.0 #3791
40c5aa0
mgsloan added a commit that referenced this issue Feb 18, 2018
@mgsloan
Use per-component build directories for ghci with Cabal>=2.0 #3791
030a442
@dbaynard
Copy link
Contributor

dbaynard commented Mar 15, 2018 •
edited
Loading

Is this supposed to fix stack ghci for libraries with internal library modules? (If not, I'll open a new issue).

Edit: #3795 does fix it spoke too soon. I'll investigate further.

@dbaynard dbaynard mentioned this issue Mar 15, 2018
Closed
@recursion-ninja recursion-ninja mentioned this issue Apr 3, 2018
Closed
@borsboom
Copy link
Contributor

borsboom commented Apr 4, 2018

@mgsloan Does this still need to be a blocking issue? Hoping to get 1.7 out the door before too long.

mgsloan added a commit that referenced this issue Apr 9, 2018
@mgsloan
Use per-component build directories for ghci with Cabal>=2.0 #3791
54afd66
@mgsloan
Copy link
Contributor Author

mgsloan commented Apr 9, 2018

I think it would be good to merge #3795 before the release. Shoudla merged it earlier for more testing, but hey. I've pushed a rebased version, will merge after that passes CI.

mgsloan added a commit that referenced this issue Apr 10, 2018
@mgsloan
Merge pull request #3795 from commercialhaskell/fix-ghci-autogen-path…
979e613 
…-3791

Use per-component build directories for ghci with Cabal>=2.0 #3791
@mgsloan mgsloan closed this as completed Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ghci type: bug
Projects
None yet
Milestone
P0: Blocking release
Development

No branches or pull requests
4 participants
@mgsloan @dbaynard @borsboom @gahag