-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stack 1.6.1 fails to pull in dependencies which stack 1.5.1 did #3631
Comments
Hmmm, I had a copy of Stack 1.7.0 (from
|
I'd say that if fixed soon, this is a good candidate for a 1.6.3 release. |
This is a direct continuation of my (now realized to be incorrect) patch in 2a52ac2. This ensures that tests and benchmarks are only switched to `buildable = True` if we're enabling them, otherwise we can end up with cyclic dependency errors.
This is a direct continuation of my (now realized to be incorrect) patch in 2a52ac2. This ensures that tests and benchmarks are only switched to `buildable = True` if we're enabling them, otherwise we can end up with cyclic dependency errors.
OK, I've opened up a PR for this, #3654. It seems to fix the problem in my testing, but if you could test ( |
More compat with buggy Cabal buildable deps #3631
This should now be resolved on both master and the stable branch, and included in the next release. Thanks for the report, please comment if the issue remains. |
General summary/comments (optional)
Given the same resolver version (lts-6.35, though any lts-6 version seems to be the same), stack 1.6.1 no longer builds the
http2
package correctly, nor packages that depend on it (likewarp
), where stack 1.5.1 did. It seems to be failing to resolve dependencies correctly - version 1.5.1 correctly downloads and builds them all.I haven't checked whether similar problems are occurring for other lts resolvers; I noticed this one because re-launching a Travis build of an old project resulted in build failures, despite nothing changing in the code and using the same resolver, OS, etc.
update: this also seems to affect the OSX version of stack 1.6.1, from https://www.stackage.org/stack/osx-x86_64.
Steps to reproduce
On a clean Ubuntu instance (works with Docker images ubuntu:trusty and ubuntu:xenial), try the following commands:
(
test-stack.sh
)Expected
Actual
Output of stack is in a gist.
Command run was:
I've also created a minimal project (which does nothing but have
http2
as a dependency), and built it using Travis CI (link here): it builds using stack 1.5.1, and fails using 1.6.1.Stack version
Method of installation
The text was updated successfully, but these errors were encountered: