-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"stack setup" output mentions "locally installed GHC" which is terribly confusing #2314
Comments
What about Will re-open upon further details. |
Running from cmd.exe (Windows Console) inside my project's folder where there is stack.yaml:
|
I couldn't not reopen it. |
Is this a misunderstanding about the line "stack will use a locally installed GHC"? It does appear as if the ghc in |
Hmm, yeah, it seems to think it is using a locally installed GHC, but the stack installed one is most immediately present on PATH Does your PATH var contain that dir? |
This is just bad wording: See Would something like this be clearer?
|
Yes, this is much more clear. |
@mgsloan, nope, my PATH doesn't contain this directory. |
Let's be cautious about the wording here. I'm worried that this message might be interpreted differently than what we intend and that the wrong impression might stick. For example "separate from any local system installations" might be interpreted as "this ghc doesn't use system-installed libraries", which is wrong… |
What about simply "stack will use a sandboxed GHC it installed"? The important bit is that stack installed this GHC, not the user, right? |
@Blaisorblade, sounds good! |
Fix #2314: Clarify output from stack setup, since it confused both a user and stack developers for a while in that issue. Also update references in other code and in the guide.
"stack will use a sandboxed GHC it installed" is a grammatical error. Should be "stack will use a sandboxed GHC if installed" ("it" -> "if") |
It doesn't mean "if" (there's no if, this message does imply that a GHC was installed) but "it", and I'm not sure what's the error. It means "a sandboxed GHC that it [stack] installed". I'm not sure about "a GHC that", but is it an error? Even if correct, if the message still sounds misleading it can be changed. |
OK, I misunderstood the intent of the message (which is, of course, the point of this issue!). I agree it's not wrong, but the issue can't really be considered resolved. Maybe we should ask, "What does the user really want to see when she types A similar example is homebrew. If I type With stack, when I type Alternately, if my system is not ready and stack needs to install a GHC it could tell me that: "Installing sandboxed GHC 7.10.3..." and then the message above when complete. The remaining lines regarding path and the other subcommands just confuse me. Why do I need to see those every time I run setup? I'm really interested in other people's opinions on this, though, since it's a matter of interpretation as well as some people might have a different use case. |
@CraigStuntz Good point. I'm reopening, but don't have time to craft a good message. Can you take the lead on this?
I think If I run I suspect this is low-priority, but I don't think people would oppose it as long as it's low impact. But elsewhere we have no mechanism for "warn for this the first time". |
I guess it would make sense to generally look at stack messages and review them for helpfulness and consistency as a whole. Looking at the code it seems the messages are distributed throughout (as opposed to, say, a localizable table), so it will take some time to assemble this. I can't promise any deadline, but I'll gather info as time permits. As you say, it's not a show stopper. |
I've started collecting stack messages in this document and will grow it as I work. My first thought is that |
That's a great idea! While looking at and improving messages, it would also be helpful to switch them to using pretty printing / colorization - #2650 . Some of this work has been done, but there's still quite a lot of stuff that isn't pretty printed. |
Agreed. To the extent it's possible, you might want to tackle issues you find incrementally, both to get feedback and motivation, and to make progress. Or at least, file sub-issues for those.
But we do have those options (ahem, we have
|
root@debian:/home/jacob/NemoChain# stack uninstall ghc-cabel Thanks bra............ |
@Gr1dd I have deleted one of your comments, please be constructive. Understand that there are technical issues here that make this nontrivial. Also, you mispelled |
on Windows 8, stack 1.1.2
There is no locally installed GHC:
The text was updated successfully, but these errors were encountered: