Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc-paths and other installation directories are hard-coded on Windows #1644

Closed
hherman1 opened this issue Jan 12, 2016 · 1 comment · Fixed by #2766
Closed

ghc-paths and other installation directories are hard-coded on Windows #1644

hherman1 opened this issue Jan 12, 2016 · 1 comment · Fixed by #2766
Labels
awaiting pull request component: Windows newcomer friendly
Milestone
P2: Should

Comments

@hherman1
Copy link

This honestly wouldn't be a problem except that the sheer nesting depth is causing node.js/ghcjs to fail at compiling ghcjs-dom. It'd be nice if ghc-paths and others depended on STACK-ROOT, or were at least somehow variable.
@borsboom borsboom added this to the P2: Should milestone Jan 13, 2016
@borsboom
Copy link
Contributor

Agreed. I think the GHC paths were set where they are to be "friendly" to the Windows way of doing things, but it ends up with really long paths which are so troublesome. There should at least be a way to change it. You might try changing the LOCALAPPDATA environment and see if that helps, but I don't think that's a great workaround (since lots of other things use that variable as well). A pull request would be welcome (the relevant code is here). Making the location configurable in STACK_ROOT\config.yaml is probably the right way to go (rather than use an environment variable).

@mgsloan mgsloan mentioned this issue Nov 7, 2016
Closed
ruuda added a commit to ruuda/stack that referenced this issue Nov 8, 2016
@ruuda
Do not special-case programs directory on Windows
8cbfca6 
Just use $STACK_ROOT/programs, like on other platforms. This enables the
directory to be configurable by setting $STACK_ROOT, and it removes the
hard-coded path. When downloading GHC, the archive is downloaded to this
directory as well before extraction. (This was the case anyway.) This is
perhaps less idiomatic, but $STACK_ROOT exists on Windows regardless, so
it seems better to keep everything in one place.

Fixes commercialhaskell#1644.
@ruuda ruuda mentioned this issue Nov 8, 2016
Merged
2 tasks
ruuda added a commit to ruuda/stack that referenced this issue Nov 26, 2016
@ruuda
Do not special-case programs directory on Windows
9731235 
Just use $STACK_ROOT/programs, like on other platforms. This enables the
directory to be configurable by setting $STACK_ROOT, and it removes the
hard-coded path. When downloading GHC, the archive is downloaded to this
directory as well before extraction. (This was the case anyway.) This is
perhaps less idiomatic, but $STACK_ROOT exists on Windows regardless, so
it seems better to keep everything in one place.

Fixes commercialhaskell#1644.
@mgsloan mgsloan mentioned this issue Feb 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting pull request component: Windows newcomer friendly
Projects
None yet
Milestone
P2: Should
Development

Successfully merging a pull request may close this issue.

Allow configuring programs directory ruuda/stack
3 participants
@hherman1 @borsboom @sjakobi