-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typos in extra-deps aren't detected #1521
Comments
* it should now detect typos commercialhaskell#1521 (package suggestions will be added in another PR)
* it should now detect typos commercialhaskell#1521 (package suggestions will be added in another PR)
In review of #1858 , this is actually quite tricky. The problem is that extra-deps might be fulfilled by packages globally installed. (e.g. docker container). Even then, we cannot be sure that it's missing in a way that should be a build failure, so it must just be a warning. The solution here is to check if the extra-dep is already installed. If it isn't already installed, check if it is in the hackage index. If it isn't, then the warning is yielded. For this repro, it looks like this:
|
Noticed this while helping L8D in #haskell
Repro:
stack new issue1521
cd issue1521
hspec >= 2.2.1
to the test-suite build-dependsextra-deps
:(Note the mis-spelled
hspec-epectations
)5)
stack test
6) Get this error:
The text was updated successfully, but these errors were encountered: