Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stack build options to stack ghci? #1186

Closed
danclien opened this issue Oct 17, 2015 · 6 comments
Closed

Add stack build options to stack ghci? #1186

danclien opened this issue Oct 17, 2015 · 6 comments
Assignees
@mgsloan
Labels
component: ghci type: enhancement
Milestone
P2: Should

Comments

@danclien
Copy link

It looks like a stack ghci will invoke a stack build without any addition options?

I normally build with stack build --executable-profiling. When I run stack ghci, it has to unregister everything in my local database and rebuild everything without profiling.

Would it be possible to add the options from stack build to stack ghci? I'm currently running v0.1.6.0 (e22271f, OS X x86_64).
@bergmark
Copy link
Member

#971

@saevarb saevarb mentioned this issue Oct 27, 2015
Closed
@mgsloan
Copy link
Contributor

mgsloan commented Oct 28, 2015

This is a good idea! It would also be good to have stack ghci follow stack build's convention of defaulting to only building libraries and executables - see this comment #817 (comment).

@borsboom
Copy link
Contributor

Yeah, I agree. Becomes even more relevant with #1228.

@borsboom borsboom added this to the P2: Should milestone Oct 29, 2015
@mgsloan mgsloan mentioned this issue Oct 29, 2015
Closed
@borsboom borsboom mentioned this issue Nov 3, 2015
Closed
This was referenced Nov 4, 2015
Closed
Closed
Closed
@mgsloan mgsloan self-assigned this Nov 11, 2015
@mgsloan mgsloan mentioned this issue Nov 11, 2015
Open
@mgsloan
Copy link
Contributor

mgsloan commented Nov 11, 2015

I'm going to go ahead with this, but not looking forward to what it will do to stack ghci --help (See #1333)

mgsloan added a commit that referenced this issue Nov 11, 2015
@mgsloan
Add stack build options to stack ghci #1186
3348ec8
@mgsloan
Copy link
Contributor

mgsloan commented Nov 11, 2015

@danclien This is now implemented!

@mgsloan mgsloan closed this as completed Nov 11, 2015
dysinger added a commit that referenced this issue Nov 13, 2015
@dysinger
Merge branch 'master' into sig-sign-sdist-and-upload-sign
a1a5960 
* master: (96 commits)
  Revert "Additional helper to get project config dir"
  Additional helper to get project config dir
  Add a few items to ChangeLog.md
  Add stack build options to stack ghci #1186
  Always build exes, due to cabal copy limitation
  Ported stack_and_ghcjs wiki page to doc
  release script: fix compile warnings
  Fix/add documentation for bcWorkDir and workDirRel
  Organize Stack.Types.Config
  Remove unused functions from Stack.Types.Config
  Fix building tests/benches in some circumstances
  Refactor generateHaddockIndex
  Enhance documentation for Stack.Build.Haddock
  Fix haddock generation
  Enhance documentation for System.Process.Read
  Enhance documentation for System.Process.Run
  Refactorings using mapMaybeM, forMaybeM and forMaybeA
  quite a few cosmetic improvements
  Enhance haddocks for Stack.Build.Execute
  Revert "Only install exes when they're built"
  ...
@danclien
Copy link
Author

Awesome. Thank you so much!

@mgsloan mgsloan mentioned this issue Jan 3, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgsloan mgsloan

Labels
component: ghci type: enhancement
Projects
None yet
Milestone
P2: Should
Development

No branches or pull requests
4 participants
@mgsloan @bergmark @danclien @borsboom