Merge pull request #4067 from markus1189/3959-flag-order

Change parsers to use `flag'` instead of `switch`

ChangeLog.md

@@ -42,6 +42,8 @@ Bug fixes:
   was tried to be registered. This is now fixed by always building internal
   libraries. See
   [#3996](https://github.com/commercialhaskell/stack/issues/3996).
+* Order of commandline arguments does not matter anymore.
+  See [#3959](https://github.com/commercialhaskell/stack/issues/3959)
 * When prompting users about saving their Hackage credentials on upload,
   flush to stdout before waiting for the response so the prompt actually
   displays.

src/Stack/Options/BenchParser.hs

@@ -19,7 +19,7 @@ benchOptsParser hide0 = BenchmarkOptsMonoid
                                  help ("Forward BENCH_ARGS to the benchmark suite. " <>
                                        "Supports templates from `cabal bench`") <>
                                  hide))
-        <*> optionalFirst (switch (long "no-run-benchmarks" <>
+        <*> optionalFirst (flag' True (long "no-run-benchmarks" <>
                           help "Disable running of benchmarks. (Benchmarks will still be built.)" <>
                              hide))
    where hide = hideMods hide0

src/Stack/Options/TestParser.hs

@@ -27,12 +27,12 @@ testOptsParser hide0 =
                          help "Arguments passed in to the test suite program" <>
                          hide)))
         <*> optionalFirst
-                (switch
+                (flag' True
                     (long "coverage" <>
                      help "Generate a code coverage report" <>
                      hide))
         <*> optionalFirst
-                (switch
+                (flag' True
                     (long "no-run-tests" <>
                      help "Disable running of tests. (Tests will still be built.)" <>
                      hide))

test/integration/tests/3959-order-of-flags/Main.hs

@@ -0,0 +1,21 @@
+import StackTest
+
+import Control.Monad (unless)
+import Data.List (isInfixOf)
+
+-- Integration test for https://github.com/commercialhaskell/stack/issues/3959
+main :: IO ()
+main = do
+  checkFlagsBeforeCommand
+  checkFlagsAfterCommand
+
+checkFlagsBeforeCommand :: IO ()
+checkFlagsBeforeCommand = stackCheckStderr ["--test", "--no-run-tests", "build"] checker
+
+checkFlagsAfterCommand :: IO ()
+checkFlagsAfterCommand = stackCheckStderr ["build", "--test", "--no-run-tests"] checker
+
+checker :: String -> IO ()
+checker output = do
+  let testsAreDisabled = any (\ln -> "Test running disabled by" `isInfixOf` ln) (lines output)
+  unless testsAreDisabled $ fail "Tests should not be run"

test/integration/tests/3959-order-of-flags/files/package.yaml

@@ -0,0 +1,10 @@
+name: issue3959
+version: 0.1.0.0
+
+dependencies:
+- base
+
+tests:
+  test:
+    main:                Spec.hs
+    source-dirs:         test

test/integration/tests/3959-order-of-flags/files/stack.yaml

@@ -0,0 +1 @@
+resolver: lts-11.6

test/integration/tests/3959-order-of-flags/files/test/Spec.hs

@@ -0,0 +1,2 @@
+main :: IO ()
+main = fail "this always fails for the test"