Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(readmes): lowercase anchor links to prevent links breaking #3062

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(readmes): lowercase anchor links to prevent links breaking #3062

wants to merge 4 commits into from

Conversation

tylermorrisford
Copy link
Contributor

@tylermorrisford tylermorrisford commented Feb 11, 2025 •
edited
Loading

Summary

This PR:

  • Fixes anchor links in READMEs to allow users to click those links and view the related prop signatures
  • Removes some syntax from the DataTable prop descriptions that broke the markdown structure of the DataTable component README

Currently the DataTable README markdown syntax is broken:
Screenshot 2025-02-11 at 10 28 39 AM

After removing the problematic syntax:
Screenshot 2025-02-11 at 10 31 40 AM

@tylermorrisford tylermorrisford self-assigned this Feb 11, 2025
@tylermorrisford tylermorrisford requested a review from a team as a code owner February 11, 2025 17:18
@tylermorrisford tylermorrisford requested review from stephsprinkle, jaikamat, ddouglasz, ByronDWall and misama-ct and removed request for a team February 11, 2025 17:18
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: c5e7894

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 5:45pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaikamat jaikamat jaikamat approved these changes

@stephsprinkle stephsprinkle Awaiting requested review from stephsprinkle stephsprinkle is a code owner automatically assigned from commercetools/first-contact-team-fe

@ddouglasz ddouglasz Awaiting requested review from ddouglasz ddouglasz is a code owner automatically assigned from commercetools/first-contact-team-fe

@ByronDWall ByronDWall Awaiting requested review from ByronDWall ByronDWall is a code owner automatically assigned from commercetools/first-contact-team-fe

@misama-ct misama-ct Awaiting requested review from misama-ct misama-ct is a code owner automatically assigned from commercetools/first-contact-team-fe

Assignees

@tylermorrisford tylermorrisford

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylermorrisford @jaikamat