Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEC-49] ShippingInfo model #726

Merged
merged 9 commits into from
Dec 12, 2024
Merged

[FEC-49] ShippingInfo model #726

merged 9 commits into from
Dec 12, 2024

Conversation

CarlosCortizasCT
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT commented Dec 9, 2024 •
edited
Loading

The idea behind this PR was to include the ShippingInfo missing model (child of the Cart one) which led to all these changes:

  • New Cart child models: TaxedItemPrice, TaxPortion and ShippingInfo.
  • New commons test data models: DicountedLineItemPortion, DicountedLineItemPortionDraft.
  • New preset (withAllFields) in the TaxCategory model.

@CarlosCortizasCT CarlosCortizasCT self-assigned this Dec 9, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2d92053

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CarlosCortizasCT CarlosCortizasCT added fe-chapter-rotation Tasks coming from frontend chapter work 🚧 Status: WIP labels Dec 9, 2024
@CarlosCortizasCT CarlosCortizasCT marked this pull request as ready for review December 9, 2024 16:22
@CarlosCortizasCT CarlosCortizasCT requested review from a team as code owners December 9, 2024 16:22
@CarlosCortizasCT CarlosCortizasCT requested a review from a team December 9, 2024 16:22
@CarlosCortizasCT CarlosCortizasCT mentioned this pull request Dec 9, 2024
Closed
ddouglasz
ddouglasz approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@ddouglasz ddouglasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏🏾

@nima-ct nima-ct self-requested a review December 12, 2024 12:37
@CarlosCortizasCT CarlosCortizasCT merged commit 3afc6db into main Dec 12, 2024
4 checks passed
@CarlosCortizasCT CarlosCortizasCT deleted the cm/fec-49-shipping-info-model branch December 12, 2024 12:49
@ct-changesets ct-changesets bot mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nima-ct nima-ct nima-ct approved these changes

@ddouglasz ddouglasz ddouglasz approved these changes

Assignees

@CarlosCortizasCT CarlosCortizasCT

Labels
fe-chapter-rotation Tasks coming from frontend chapter work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CarlosCortizasCT @ddouglasz @nima-ct