Kycfile contract #204
Kycfile contract #204
Conversation
…ycpubkey. Fix onboard RPC tests.
|
|
||
| void CWhiteList::sync_whitelist_wallet(){ | ||
| boost::recursive_mutex::scoped_lock scoped_lock(_mtx); | ||
| std::vector<CPubKey> keysNotFound; |
There was a problem hiding this comment.
This vector is only used inside sync_whitelist_wallet. why do we need two methods for this?
There was a problem hiding this comment.
I don't see where keysNotFound is used.
There was a problem hiding this comment.
I may add an RPC for this if needed - keysNotFound will be used for that.
src/wallet/rpcdump.cpp
Outdated
| CPubKey pubKey; | ||
| if(Params().ContractInTx()){ | ||
| pubKey=key.GetPubKey(); | ||
| } else { |
There was a problem hiding this comment.
This should be if (Params().EmbedContract() &! bEncryption) no? That is condition for applying tweaking in GenerateNewKey() in wallet.cpp. I am not sure why bEncryption was added.
There was a problem hiding this comment.
Actually GenerateNewKey() tweaks the key under the following condition:
Params().EmbedContract() && Params().ContractInTx() &! contract.IsNull()
I have updated accordingly.
"bEncryption" is key dependent and is "true" for generating keys in the "encryption" HD path as these keys do not need to be tweaked.
There was a problem hiding this comment.
Sorry was checking old code. It tweaks when !Params().ContractInTx() but your statement now will tweak even when embed contract is disabled.
There was a problem hiding this comment.
It doesn't make any difference because without tweaking pubKey and derivedPubKey are the same, so I've removed the check and just used derivedPubKey.
New RPCs:
-- dumpkycpubkeys
-- removekycpubkey
Fixes to onboarding with contractintx.