HostFS: Fix behavior of realpath() on Windows. Clear carry flag on return from hostfs ACPTR #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fleshed out the behavior of Windows realpath() emulation to follow proper behavior if the second arg is not NULL, even though all of the current uses of the function in the project pass NULL in the second arg. |
|
Looks fine to me. Thanks for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two distinct problems.
_fullpath() on windows returns a valid path even if the final part does not exist. This differs from the behavior of realpath(), so I changed the macro into a function call that implements realpath() behavior on Windows.
Emulated ACPTR was leaving the state of the carry flag alone, which confuses BASIC if it's not cleared.. This is the counterpart of the behavior for write that was described in #416 which I had fixed in the main hostfs PR, but for reading instead of writing. The real ROM code clears carry unconditionally on return from ACPTR, so the hostfs code must as well.