Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugger enhancements V2 - new hardware #338

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

Debugger enhancements V2 - new hardware #338

wants to merge 46 commits into from

Conversation

kktos
Copy link
Contributor

@kktos kktos commented Mar 29, 2021

No description provided.

kktos added 30 commits December 3, 2020 19:27
@kktos
Add Debugger Console.
8c99a16 
Add a whole bunch of command
Add Debugger in a window.
Add INI file.
@kktos
Add font command
ec24ce9
@kktos
Fix debugger INI name
79002ef
@kktos
Add Debugger Console.
666aed8 
Add a whole bunch of command
Add Debugger in a window.
Add INI file.
@kktos
Update INI read to handle NUM_JOYSTICKS
c99e4b3
@kktos
Add font command
a709d52
@kktos
Fix debugger INI name
cce2d4d
@kktos
Add colours in INI / Make the layout adaptive to current debugger font
abd0231 
(cherry picked from commit b3c2648)
@kktos
add layout setup function and fix cmd help
ef86184 
(cherry picked from commit 739e1a7)
@kktos
Add cmd "data"
58a0fa4 
(cherry picked from commit 879fd7e)
@kktos
Add cmd "info"
74167cb 
(cherry picked from commit 7fad3e4)
@kktos
Fix event handling to close app
5288844 
(cherry picked from commit a8e546d)
@kktos
Remove unused files
de120db 
(cherry picked from commit 7026084)
@kktos
Add missing info file !
f87cc31 
(cherry picked from commit 5a9f652)
@kktos
Add OBJ directories
2f48751 
(cherry picked from commit 1975d5b)
@kktos
Fix bug on load font - basename() was crashing
45b3259 
Load a font only once

(cherry picked from commit d56fa03)
@kktos
add assets/fonts
756b758 
(cherry picked from commit 0a5654a)
@kktos
Update Makefile
690563e 
(cherry picked from commit b91bf9f)
@kktos
Add option to display or not mouseCoord in DBG
97a42e9 
(cherry picked from commit 5d93f1e)
@kktos
Fix help on command d/b
e1393c2 
(cherry picked from commit 38e0a15)
@kktos
Fix make clean to remove obj files in all sub dir
dcda5ab 
(cherry picked from commit 1f2aaf9)
@kktos
Fix bad include path for debugger.h
6a5ed5c 
(cherry picked from commit 23fb30f)
@kktos
Add a rule in %Makefile to create the dirs in OBJ : make OBJ_DIRS
1346bc3 
(cherry picked from commit ffd1eeb)
@kktos
Fix disasm for BRANCH operation to display the symbol label if define…
70f635e 
…d - Thx S. Horn

(cherry picked from commit bf642d8)
@kktos
Add colours settings in INI for labels, data and highlight
dd5d8aa 
(cherry picked from commit a05de23)
@kktos
Add missing command "e" for VRAM
8c3df20 
(cherry picked from commit 3781601)
@kktos
Add command "sh" search memory
42ea823 
(cherry picked from commit 368a835)
@kktos
Add BP on memory access
db9e44e 
Slighty enhanced disasm to fall on right line ... still not perfect
@kktos
lint a bunch of modified files
3ba7acf 
(cherry picked from commit c0a61c0)
@kktos
Comment out the ability to exit the console : ESC key
4daad28 
(cherry picked from commit d082739)
kktos added 15 commits March 28, 2021 18:15
@kktos
Fix command "sym" by making parm mandatory
dd7d316 
(cherry picked from commit aace16e)
@kktos
Truncate symbol to 14 chars in order to find them (bp longsymbolname …
06f35da 
…wasn't finding the symbol)

Fix the symbol eval to return not found instead of addr 0 when not found

(cherry picked from commit 409f78f)
@kktos
Fix commands se? / cl? - wrong bits !
8f58163 
Fix mouse coord display

(cherry picked from commit 355252e)
@kktos
Fix cpu registers X and Y display
11cc7f8 
(cherry picked from commit 9aa9507)
@kktos
Fix disasm view width to handle LDA symbol,X
1425c27 
Fix user symbol file loader to handle empty lines and lines commented out ";"

(cherry picked from commit 85af12d)
@kktos
Fix code view to highlight current PC
486c67e 
Fix in DebugInit to handle no ini file

(cherry picked from commit 7c6416d)
@kktos
Add handling of paste to the console (CTRL-C)
6ef93df 
Add command "load file addr"
Fix symbol lookup to search either a symbol or an address
Fix the disasm Bank to follow the current one depending of RAM or ROM
Fix disasm to display symbol depending on the current bank (ROM/RAM)
Disams: Change the label pos for a full line

(cherry picked from commit ea2b5c6)
@kktos
Fix paste kbd assignment (MAC / WIN)
3d63318 
(cherry picked from commit 0064a5c)
@kktos
Fix breakpoint to handle selected bank
712ddbd 
(cherry picked from commit 0e3678d)
@kktos
Add bp on mem write and read
9deb9e9 
Fix the load command
@kktos
Add timer commands (time, timelog, timeend)
c1f5739 
Add debugger settings var (romdebug flag to allow ROM modif, bp_on_brk to have BRK viewed as breakpoint)

(cherry picked from commit 38c8795)
@kktos
Add very primitive UI on the main window
45fe7b8 
Remove the keyboard shortcuts as they are replaced by buttons
Allow to redefine keyboard bindings for the DBG

(cherry picked from commit 3dfc2f5)
@kktos
Add to UI a btn to call the debugger - replace F12
e7e5786 
Fix the key bindings to handle the mods

(cherry picked from commit 72c932f)
@kktos
Fix command "e" & "f" to handle ROM - thru rom_debug flag
98e2e9e 
Allow command "load" to load in main RAM, banked RAM and banked ROM
Add key bindings for bank up/down on memory dump

(cherry picked from commit 5e6fd08)
@kktos
Restore src/via.c - was badly merged
d708eaf
@kktos kktos mentioned this pull request Mar 29, 2021
Closed
@mist64
Copy link
Collaborator

mist64 commented Apr 4, 2021

Sorry, I missed this in time, and now we have conflicts again.

I tried to resolve the conflicts myself, but having played with it for a while, I really think this needs to be done in three steps:

  1. reorganize the directory structure
  2. clean up the source
  3. add the new debugger features

Could you do this? :) Ping me at [email protected] once the first patch is ready, so I can apply it immediately, and it does not fall behind any more. The other two will then be less time critical.

@mist64
Copy link
Collaborator

mist64 commented Apr 4, 2021

For reference: documentation is in #313.

@mist64
Copy link
Collaborator

mist64 commented Apr 4, 2021

I moved all sources to src/ and .o files to build/ (to be consistent with the ROM build process) in 61fc63d, so one less step here.

@mist64
Copy link
Collaborator

mist64 commented Apr 4, 2021

So for the remaining changes, I'd like to have them broken up like this:

  1. split up debugger.c/.h and move it into a subdirectory, together with disasm.c/.h
  2. debugger cleanup & feature work

and independently: cleanup work in the non-debugger code

@mist64
Copy link
Collaborator

mist64 commented Apr 4, 2021

I separated out 1./2. into branch https://github.com/commanderx16/x16-emulator/tree/kktos-debugger-enhancements - maybe it's useful for a start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kktos @mist64